Commit efaa239
authored
acc: run deployment/bind/alert locally on all clouds (#5719)
## Changes
Run `acceptance/bundle/deployment/bind/alert` against the local
testserver in addition to cloud (`Local = true`). No testserver changes
needed — alerts-v2 create/bind/unbind and `bundle summary` are already
modeled by the fake (the same support the already-local
`resources/alerts/{basic,with_file}` tests rely on).
The only local-vs-cloud divergence was the summary URL. `InitializeURLs`
appends `?w=<workspace id>` when the host doesn't carry the ID in its
subdomain — true for the local testserver (`127.0.0.1`) and aws, but not
azure/gcp vanity hosts. So:
- Added a repl stripping `\?[ow]=\d+` (`Order = 0`, before the global
`[NUMID]` repls), matching `resources/alerts/{basic,with_file}`.
- Dropped the now-unnecessary `CloudEnvs.aws = false` skip, since the
repl normalizes aws too.
## Why
Part of converting `Local = false` acceptance tests to local+cloud. The
`?w=` isn't a testserver fidelity gap — it's correct CLI behavior driven
by host shape, and ~55 existing local goldens already record
`?w=[NUMID]`. Redaction keeps one golden valid across local and all
clouds, and net coverage increases (local + aws/azure/gcp vs cloud-only
before).
## Tests
No additional tests.1 parent e18ef74 commit efaa239
2 files changed
Lines changed: 11 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | 9 | | |
13 | 10 | | |
14 | 11 | | |
15 | 12 | | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
0 commit comments