From 9c25093244a09fa9e8b6c76a093da9c2b8eeb415 Mon Sep 17 00:00:00 2001 From: Youichi Uda Date: Sun, 19 Apr 2026 08:19:59 +0900 Subject: [PATCH] chore: fix clippy warnings surfaced by Rust 1.95 Rust 1.95 / clippy 1.95 promoted two lints to warnings which now fail CI under `-D warnings`: - `clippy::useless_conversion` in `src/row_index.rs`: drop the redundant `.into_iter()` in a `zip()` argument. - `clippy::explicit_counter_loop` in `src/encoding/integer/rle_v2/delta.rs`: rewrite two manual counter loops in the test module with `.enumerate()`. No behaviour change; CI on `main` is currently green because the last push predates the Rust 1.95 release, but any new PR hits these warnings. --- src/encoding/integer/rle_v2/delta.rs | 12 ++++-------- src/row_index.rs | 2 +- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/src/encoding/integer/rle_v2/delta.rs b/src/encoding/integer/rle_v2/delta.rs index c3b0bfd..8e4072d 100644 --- a/src/encoding/integer/rle_v2/delta.rs +++ b/src/encoding/integer/rle_v2/delta.rs @@ -250,10 +250,8 @@ mod tests { .unwrap(); let mut expected = vec![0, 10]; - let mut i = 1; - for d in deltas { - expected.push(d + expected[i]); - i += 1; + for (i, d) in deltas.into_iter().enumerate() { + expected.push(d + expected[i + 1]); } assert_eq!(expected, out); } @@ -279,10 +277,8 @@ mod tests { .unwrap(); let mut expected = vec![10_000, 9_999]; - let mut i = 1; - for d in deltas { - expected.push(expected[i] - d); - i += 1; + for (i, d) in deltas.into_iter().enumerate() { + expected.push(expected[i + 1] - d); } assert_eq!(expected, out); } diff --git a/src/row_index.rs b/src/row_index.rs index 9289bb3..6985dc1 100644 --- a/src/row_index.rs +++ b/src/row_index.rs @@ -280,7 +280,7 @@ pub fn parse_stripe_row_indexes( filters.len(), column_id ); - for (entry, bloom) in row_group_index.entries_mut().zip(filters.into_iter()) { + for (entry, bloom) in row_group_index.entries_mut().zip(filters) { entry.bloom_filter = Some(bloom); } }