Skip to content

Refine .opencodereview/rule.json with project-specific review rules #3

@vanducng

Description

@vanducng

A minimal .opencodereview/rule.json was added so OpenCodeReview runs on PRs (see the org-wide Code Review workflow from dataplanelabs/workflows).

Current rules cover shell scripts and Dockerfiles. As the codebase grows (noVNC/remote-desktop container, start.sh, any added app code), tailor the rules accordingly.

Todo:

  • harden start.sh rules (signal handling, process supervision, no secrets in env/logs)
  • if app code is added, add language-specific rules
  • review Dockerfile for least-privilege user and pinned base image/digest

Rule format/docs: https://github.com/dataplanelabs/workflows#review-rules

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions