From 86dc324e64a50c33d90fb308921b460fd33b9b45 Mon Sep 17 00:00:00 2001 From: Zach Smith Date: Tue, 28 Apr 2026 09:38:24 -0700 Subject: [PATCH 1/2] fix: wire BUILD_IROH_SERVICES_API_KEY into bundle and release workflows The diagnostics module reads BUILD_IROH_SERVICES_API_KEY via option_env!() at compile time as a fallback when the runtime IROH_SERVICES_API_KEY isn't set, but neither workflow exported the secret to the build env, so released apps shipped without a key baked in and logged "Net diagnostics disabled: IROH_SERVICES_API_KEY not set" on launch. Co-Authored-By: Claude Opus 4.7 (1M context) --- .github/workflows/bundle.yml | 1 + .github/workflows/manual-release.yml | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/workflows/bundle.yml b/.github/workflows/bundle.yml index f9f175a..d4771d2 100644 --- a/.github/workflows/bundle.yml +++ b/.github/workflows/bundle.yml @@ -19,6 +19,7 @@ jobs: env: BUILD_N0DES_API_SECRET: ${{ secrets.N0DES_API_SECRET }} + BUILD_IROH_SERVICES_API_KEY: ${{ secrets.BUILD_IROH_SERVICES_API_KEY }} BUILD_DATUM_CONNECT_RELAY_URLS: ${{ vars.BUILD_DATUM_CONNECT_RELAY_URLS }} BUILD_DATUM_CONNECT_CREATE_TRAFFIC_PROTECTION_POLICIES: ${{ vars.BUILD_DATUM_CONNECT_CREATE_TRAFFIC_PROTECTION_POLICIES }} DATUM_API_ENV: production diff --git a/.github/workflows/manual-release.yml b/.github/workflows/manual-release.yml index 5b24967..5834fa1 100644 --- a/.github/workflows/manual-release.yml +++ b/.github/workflows/manual-release.yml @@ -23,6 +23,7 @@ jobs: env: BUILD_N0DES_API_SECRET: ${{ secrets.N0DES_API_SECRET }} + BUILD_IROH_SERVICES_API_KEY: ${{ secrets.BUILD_IROH_SERVICES_API_KEY }} BUILD_DATUM_CONNECT_RELAY_URLS: ${{ vars.BUILD_DATUM_CONNECT_RELAY_URLS }} BUILD_DATUM_CONNECT_CREATE_TRAFFIC_PROTECTION_POLICIES: ${{ vars.BUILD_DATUM_CONNECT_CREATE_TRAFFIC_PROTECTION_POLICIES }} DATUM_API_ENV: production From b5e97b993e1eb08cfee2ebc71b88f74944cdcd9e Mon Sep 17 00:00:00 2001 From: Zach Smith Date: Tue, 28 Apr 2026 10:32:10 -0700 Subject: [PATCH 2/2] fix: pin dioxus-primitives to a known-good rev The dep was declared with a bare git URL and no rev pin. Combined with bundle CI's `cargo generate-lockfile` step (which discards the committed lockfile before `dx bundle --locked`), every CI run resolved upstream HEAD. Upstream just landed a Select API change (`value` is now `Option>>` and `placeholder` was removed), breaking the bundle build with no source changes on our side. Pin to ffbc750 (the rev currently in Cargo.lock and the last known to build cleanly), matching the same approach used for the recent pkcs8 pin. Bumps should be deliberate going forward. Co-Authored-By: Claude Opus 4.7 (1M context) --- Cargo.lock | 36 ++++++++++++++++++------------------ ui/Cargo.toml | 6 +++++- 2 files changed, 23 insertions(+), 19 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index b534e8d..8b3e5bd 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1952,7 +1952,7 @@ dependencies = [ [[package]] name = "dioxus-attributes" version = "0.1.0" -source = "git+https://github.com/DioxusLabs/components#ffbc750181ea2195e20736ae3ad0c24ad9684c41" +source = "git+https://github.com/DioxusLabs/components?rev=ffbc750181ea2195e20736ae3ad0c24ad9684c41#ffbc750181ea2195e20736ae3ad0c24ad9684c41" dependencies = [ "dioxus-rsx", "proc-macro2", @@ -2328,7 +2328,7 @@ dependencies = [ [[package]] name = "dioxus-primitives" version = "0.0.1" -source = "git+https://github.com/DioxusLabs/components#ffbc750181ea2195e20736ae3ad0c24ad9684c41" +source = "git+https://github.com/DioxusLabs/components?rev=ffbc750181ea2195e20736ae3ad0c24ad9684c41#ffbc750181ea2195e20736ae3ad0c24ad9684c41" dependencies = [ "dioxus", "dioxus-attributes", @@ -4937,9 +4937,9 @@ dependencies = [ [[package]] name = "js-sys" -version = "0.3.95" +version = "0.3.97" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "2964e92d1d9dc3364cae4d718d93f227e3abb088e747d92e0395bfdedf1c12ca" +checksum = "a1840c94c045fbcf8ba2812c95db44499f7c64910a912551aaaa541decebcacf" dependencies = [ "cfg-if", "futures-util", @@ -7957,9 +7957,9 @@ dependencies = [ [[package]] name = "rustls" -version = "0.23.39" +version = "0.23.40" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "7c2c118cb077cca2822033836dfb1b975355dfb784b5e8da48f7b6c5db74e60e" +checksum = "ef86cd5876211988985292b91c96a8f2d298df24e75989a43a3c73f2d4d8168b" dependencies = [ "aws-lc-rs", "log", @@ -9996,9 +9996,9 @@ dependencies = [ [[package]] name = "wasm-bindgen" -version = "0.2.118" +version = "0.2.120" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "0bf938a0bacb0469e83c1e148908bd7d5a6010354cf4fb73279b7447422e3a89" +checksum = "df52b6d9b87e0c74c9edfa1eb2d9bf85e5d63515474513aa50fa181b3c4f5db1" dependencies = [ "cfg-if", "once_cell", @@ -10009,9 +10009,9 @@ dependencies = [ [[package]] name = "wasm-bindgen-futures" -version = "0.4.68" +version = "0.4.70" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "f371d383f2fb139252e0bfac3b81b265689bf45b6874af544ffa4c975ac1ebf8" +checksum = "af934872acec734c2d80e6617bbb5ff4f12b052dd8e6332b0817bce889516084" dependencies = [ "js-sys", "wasm-bindgen", @@ -10019,9 +10019,9 @@ dependencies = [ [[package]] name = "wasm-bindgen-macro" -version = "0.2.118" +version = "0.2.120" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "eeff24f84126c0ec2db7a449f0c2ec963c6a49efe0698c4242929da037ca28ed" +checksum = "78b1041f495fb322e64aca85f5756b2172e35cd459376e67f2a6c9dffcedb103" dependencies = [ "quote", "wasm-bindgen-macro-support", @@ -10029,9 +10029,9 @@ dependencies = [ [[package]] name = "wasm-bindgen-macro-support" -version = "0.2.118" +version = "0.2.120" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "9d08065faf983b2b80a79fd87d8254c409281cf7de75fc4b773019824196c904" +checksum = "9dcd0ff20416988a18ac686d4d4d0f6aae9ebf08a389ff5d29012b05af2a1b41" dependencies = [ "bumpalo", "proc-macro2", @@ -10042,9 +10042,9 @@ dependencies = [ [[package]] name = "wasm-bindgen-shared" -version = "0.2.118" +version = "0.2.120" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "5fd04d9e306f1907bd13c6361b5c6bfc7b3b3c095ed3f8a9246390f8dbdee129" +checksum = "49757b3c82ebf16c57d69365a142940b384176c24df52a087fb748e2085359ea" dependencies = [ "unicode-ident", ] @@ -10098,9 +10098,9 @@ dependencies = [ [[package]] name = "web-sys" -version = "0.3.95" +version = "0.3.97" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "4f2dfbb17949fa2088e5d39408c48368947b86f7834484e87b73de55bc14d97d" +checksum = "2eadbac71025cd7b0834f20d1fe8472e8495821b4e9801eb0a60bd1f19827602" dependencies = [ "js-sys", "wasm-bindgen", diff --git a/ui/Cargo.toml b/ui/Cargo.toml index 98967ad..d54733e 100644 --- a/ui/Cargo.toml +++ b/ui/Cargo.toml @@ -39,7 +39,11 @@ data-encoding.workspace = true uuid.workspace = true n0-error.workspace = true rustls.workspace = true -dioxus-primitives = { git = "https://github.com/DioxusLabs/components", version = "0.0.1", default-features = false } +# Pinned to a known-good rev: the upstream repo is a moving 0.0.1 git dep +# with no published versioning, and bundle CI runs `cargo generate-lockfile`, +# so without a rev pin every CI run picks up upstream HEAD and breaks +# whenever the Select/Props API drifts. Bump deliberately, never via auto-resolve. +dioxus-primitives = { git = "https://github.com/DioxusLabs/components", rev = "ffbc750181ea2195e20736ae3ad0c24ad9684c41", version = "0.0.1", default-features = false } sentry.workspace = true [features]