Snippets does not include the entire SCClassLibrary

[salkin-mada]

SCNvim.sc *generateSnippets is not creating snippets of full Class Library / Tree (- the first level meta_ classes). Subclasses are missing. Example: Limiter, LFNoise1, LFDClipNoise, BrownNoise and PinkNoise are not included in the snippets.

Expected behavior
All classes in the Class Library should be in the generated supercollider.snippets file

Steps to reproduce
Setup scnvim and run :SCNvimTags

Information

• nvim --version: v0.3.4 / v0.4.3
• Operating system: Debian 10 / Ubuntu 19.10
• Running scnvim in a Terminal/GUI: Kitty

[salkin-mada]

In the *generateSnipptes method we need to include class.subclasses. Can make a PR.

[sadguitarius]

Hi @davidgranstrom, I was doing a little work on resolving this and realized you may have already done some in the last 5 years. Following the closed PR it sounded like you had a plan. What's the current status here? Happy to help out!

[davidgranstrom]

@sadguitarius Hi! Thanks for inquiring. The long term idea (from my perspective) is to move the snippet generators from scnvim "core" and instead implement the generator(s) as scnvim extensions. I think that this would be a better approach long term since the ecosystem of snippet plugins is subject to change and this will reduce the moving parts in the code base. Perhaps there could be a generic API for snippets in scnvim that could be used by said extensions to simplify mappings later on.

[sadguitarius]

That sounds good and makes sense to me. Would you consider utility functions for method discovery to be something that should stay in the scnvim core? And then abstracting away everything that's specific to individual snippet systems in their own extensions?

[sadguitarius]

Hi @davidgranstrom, I was wondering if there's been any movement on the plugin system for snippet generation that would help out here. I'm still running my own fork for subclass discovery which works fine, but I'd love to help out with a more robust solution if there's a known direction you'd like to take with this. Thank you!

[sadguitarius]

and just a quick update, I tried traversing the entire class hierarchy to generate snippets and this resulted in a snippets table that was too massive for luasnip to process, so maybe my quick and dirty approach is fine? I have an updated version here (with another fix for JSON generation). It at least catches all of the classes mentioned in the original post for this issue. Also I'm happy to do the work to split things out so that snippet generation is in a separate extension once it's decided what direction to take with this.