コレクションの時点では順序をもたないのでリネーム

Author: irof

jig-core/src/main/java/org/dddjava/jig/adapter/excel/ListAdapter.java

@@ -24,7 +24,7 @@
 import org.dddjava.jig.domain.model.knowledge.adapter.DatasourceAngles;
 import org.dddjava.jig.domain.model.knowledge.core.ServiceAngles;
 import org.dddjava.jig.domain.model.knowledge.core.usecases.StringComparingMethodList;
-import org.dddjava.jig.domain.model.knowledge.smell.MethodSmellList;
+import org.dddjava.jig.domain.model.knowledge.smell.MethodSmells;
 import org.dddjava.jig.domain.model.knowledge.validations.Validations;
 
 import java.nio.file.Path;
@@ -52,7 +52,7 @@ public ListAdapter(JigDocumentContext jigDocumentContext, JigService jigService)
     @HandleDocument(JigDocument.BusinessRuleList)
     public ReportBook businessRuleReports(JigRepository jigRepository) {
 
-        MethodSmellList methodSmellList = jigService.methodSmells(jigRepository);
+        MethodSmells methodSmells = jigService.methodSmells(jigRepository);
         JigTypes jigTypes = jigService.jigTypes(jigRepository);
         var allClassRelations = TypeRelationships.from(jigTypes);
 
@@ -133,7 +133,7 @@ public ReportBook businessRuleReports(JigRepository jigRepository) {
                         ReportItem.ofString("NULL判定をしている", item -> markIfTrue(item.nullDecision())),
                         ReportItem.ofString("真偽値を返している", item -> markIfTrue(item.returnsBoolean())),
                         ReportItem.ofString("voidを返している", item -> markIfTrue(item.returnsVoid()))
-                ), methodSmellList.list())
+                ), methodSmells.list())
         );
     }
 

jig-core/src/main/java/org/dddjava/jig/application/JigService.java

@@ -25,7 +25,7 @@
 import org.dddjava.jig.domain.model.knowledge.adapter.DatasourceAngles;
 import org.dddjava.jig.domain.model.knowledge.core.ServiceAngles;
 import org.dddjava.jig.domain.model.knowledge.core.usecases.StringComparingMethodList;
-import org.dddjava.jig.domain.model.knowledge.smell.MethodSmellList;
+import org.dddjava.jig.domain.model.knowledge.smell.MethodSmells;
 
 import java.util.List;
 import java.util.Map;
@@ -80,8 +80,8 @@ public JigTypes coreDomainJigTypes(JigRepository jigRepository) {
         });
     }
 
-    public MethodSmellList methodSmells(JigRepository jigRepository) {
-        return MethodSmellList.from(coreDomainJigTypes(jigRepository));
+    public MethodSmells methodSmells(JigRepository jigRepository) {
+        return MethodSmells.from(coreDomainJigTypes(jigRepository));
     }
 
     public JigTypes categoryTypes(JigRepository jigRepository) {

…del/knowledge/smell/MethodSmellList.java …/model/knowledge/smell/MethodSmells.javajig-core/src/main/java/org/dddjava/jig/domain/model/knowledge/smell/MethodSmellList.java renamed to jig-core/src/main/java/org/dddjava/jig/domain/model/knowledge/smell/MethodSmells.java jig-core/src/main/java/org/dddjava/jig/domain/model/knowledge/smell/MethodSmellList.java renamed to jig-core/src/main/java/org/dddjava/jig/domain/model/knowledge/smell/MethodSmells.java

@@ -9,10 +9,10 @@
 /**
  * メソッドの不吉なにおい一覧
  */
-public record MethodSmellList(Collection<MethodSmell> smells) {
+public record MethodSmells(Collection<MethodSmell> smells) {
 
-    public static MethodSmellList from(JigTypes jigTypes) {
-        return new MethodSmellList(jigTypes.orderedStream()
+    public static MethodSmells from(JigTypes jigTypes) {
+        return new MethodSmells(jigTypes.orderedStream()
                 .flatMap(jigType -> jigType.instanceJigMethodStream()
                         .flatMap(method -> MethodSmell.createMethodSmell(method, jigType).stream())
                 )

…knowledge/smell/MethodSmellListTest.java …el/knowledge/smell/MethodSmellsTest.javajig-core/src/test/java/org/dddjava/jig/domain/model/knowledge/smell/MethodSmellListTest.java renamed to jig-core/src/test/java/org/dddjava/jig/domain/model/knowledge/smell/MethodSmellsTest.java jig-core/src/test/java/org/dddjava/jig/domain/model/knowledge/smell/MethodSmellListTest.java renamed to jig-core/src/test/java/org/dddjava/jig/domain/model/knowledge/smell/MethodSmellsTest.java

@@ -22,13 +22,13 @@
 
 
 @JigServiceTest
-class MethodSmellListTest {
+class MethodSmellsTest {
 
     @Test
     void 注意メソッドの抽出(JigService jigService, JigRepository jigRepository) {
-        MethodSmellList methodSmellList = jigService.methodSmells(jigRepository);
+        MethodSmells methodSmells = jigService.methodSmells(jigRepository);
 
-        var detectedSmells = methodSmellList.list().stream()
+        var detectedSmells = methodSmells.list().stream()
                 .filter(methodSmell -> methodSmell.method().declaringType().equals(TypeId.from(SmelledClass.class)))
                 .toList();
 
@@ -58,10 +58,10 @@ private static MethodSmell extractMethod(List<MethodSmell> detectedSmells, Strin
     @ParameterizedTest(name = "{index} {1} :: {0}")
     void メンバ未使用の判定(Class<?> clz, String name, boolean expected) {
         var jigType = TestSupport.buildJigType(clz);
-        MethodSmellList methodSmellList = MethodSmellList.from(new JigTypes(List.of(jigType)));
+        MethodSmells methodSmells = MethodSmells.from(new JigTypes(List.of(jigType)));
 
         // smellListに入っていないものは警告なしの判定になるのでfilterとanyMatchで検証
-        assertEquals(expected, methodSmellList.list().stream()
+        assertEquals(expected, methodSmells.list().stream()
                 .filter(methodSmell -> methodSmell.method().name().equals(name))
                 .anyMatch(MethodSmell::notUseMember)
         );
@@ -103,9 +103,9 @@ private static MethodSmell extractMethod(List<MethodSmell> detectedSmells, Strin
      */
     @Test
     void 注意メソッドの抽出_record(JigService jigService, JigRepository jigRepository) {
-        MethodSmellList methodSmellList = jigService.methodSmells(jigRepository);
+        MethodSmells methodSmells = jigService.methodSmells(jigRepository);
 
-        var detectedSmells = methodSmellList.list().stream()
+        var detectedSmells = methodSmells.list().stream()
                 .filter(methodSmell -> methodSmell.method().declaringType().equals(TypeId.from(SmelledRecord.class)))
                 .toList();