Finding
File: tests/test_report_html.py:2568
Severity: Minor
Description
The new TestPhaseTimelineDotColoring test class does not exercise the skipped-phase code path. The template passes phase.status through directly for skipped phases, but this behavior is not covered by any test in the new class.
Suggested Fix
Add a test_skipped_phase_has_skipped_dot test to TestPhaseTimelineDotColoring that verifies a phase with status='skipped' produces a dot element containing the phase-status-skipped class (or whatever the template renders for that status). This would complete coverage of all phase status variants.
Note: this is pre-existing behavior that was not introduced by the PR, so it is a follow-up improvement rather than a regression.
Reference
Found during review of PR #270 (fix: HTML report phase timeline ordering and rework coloring). Did not block the PR.
Finding
File:
tests/test_report_html.py:2568Severity: Minor
Description
The new
TestPhaseTimelineDotColoringtest class does not exercise the skipped-phase code path. The template passesphase.statusthrough directly for skipped phases, but this behavior is not covered by any test in the new class.Suggested Fix
Add a
test_skipped_phase_has_skipped_dottest toTestPhaseTimelineDotColoringthat verifies a phase withstatus='skipped'produces a dot element containing thephase-status-skippedclass (or whatever the template renders for that status). This would complete coverage of all phase status variants.Note: this is pre-existing behavior that was not introduced by the PR, so it is a follow-up improvement rather than a regression.
Reference
Found during review of PR #270 (fix: HTML report phase timeline ordering and rework coloring). Did not block the PR.