Skip to content

[Code scan] Make bundled simplify skill templates schema-valid #1918

Description

@njzjz

This issue is from a Codex global scan of the repository.

Some bundled skills/dpgen-simplify templates do not validate against DP-GEN's simplify inputs, so following the skill can produce invalid configuration files.

Evidence:

"pick_data": "/path/to/qm7/deepmd_npy",
"init_data_prefix": "",
"init_data_sys": [],
"sys_batch_size": [
"auto"
],
"numb_models": 4,

"fp_style": "gaussian",
"shuffle_poscar": false,
"fp_task_max": 1000,
"fp_task_min": 10,
"fp_pp_path": "/path/to/fp/support/files",
"fp_pp_files": [],
"fp_params": {

"train": {
"command": "dp",
"machine": {
"batch_type": "Shell",
"context_type": "LazyLocalContext",
"local_root": "./",
"remote_root": "./"
},
"resources": {
"number_node": 1,
"cpu_per_node": null,
"gpu_per_node": null,
"group_size": 1
}

"fp": {
"command": null,
"machine": {
"batch_type": "Shell",
"context_type": "LazyLocalContext",
"local_root": "./",
"remote_root": "./"
},
"resources": {
"number_node": 1,
"cpu_per_node": null,
"gpu_per_node": null,
"group_size": 1
}

The QM7 parameter example omits required simplify fields such as sys_configs and includes keys rejected by the simplify schema, including shuffle_poscar and VASP-style pseudopotential fields for a Gaussian example. The local-shell machine template puts batch_type under machine, while DP-GEN's current dispatcher schema expects batch_type in the resources block for these machine definitions.

Expected behavior: update the skill assets so they pass simplify_jdata_arginfo() / simplify machine validation before recommending them to users.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status
    Todo

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions