Skip to content

Audience claim aud on JWT does not include port #9

Description

@nneskildsf

Hi

This library formats the aud claim as f"{endpoint.scheme}://{endpoint.host}". The competing library pywebpush does it slightly differently. They use urlparse and format as f"{url.scheme}://{url.netloc}" with netloc being equivalent to f"{url.host}:{url.port}".

The conclusion is that this library does not include the port in the aud claim while other implementations do. In a realistic use case, no port will be specified and both libraries will reach the same aud claim.

I don't think this is a problem as such but it is notable.

Br Eskild

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions