doen't respond to SIGINT (ctrl+c)

[danielb2]

if there's no internet connection, prettyping will just hang. it's a bad experience

[denilsonsa]

Cannot reproduce.

Please include enough information in a bug report. Stuff such as:

• What OS?
• What version of bash, awk, ping?
• What kind of connection?
• Specifically, what do you mean by "if there's no internet connection"?
  • The Wi-Fi or Ethernet are disconnected.
  • The Wi-Fi or Ethernet are connected, but halfway through the path the is a failure and thus the packets can't be routed.
  • Something else entirely.
• What is the behavior with the plain ping?

Feel free to reopen after providing enough details to be able to reproduce this issue.

[danielb2]

$ uname -a
Darwin shanks 24.4.0 
$ awk --version
awk version 20200816
$ bash --version
GNU bash, version 5.2.37(1)-release (aarch64-apple-darwin23.4.0)

Steps to reproduce:

1. connect to a expired wireguard VPN
2. execute prettyping and try to ctrl+c

Note, ping will handle the SIGINT just fine.

---

example wireguard config to be able to reproduce:

[Interface]
PrivateKey = jUBk5g6Rd/ZlPZx9POshE15o9Mq/E+puedN9XGs0JkU=
Address = 100.96.3.21/32
DNS = 198.18.0.1, 198.18.0.2

[Peer]
PublicKey = 9j+g1BCYrDTEvoOo1WqPVZ07aLng5+85jCv+bCGGeAw=
AllowedIPs = 0.0.0.0/0
Endpoint = 216.131.114.108:51820

you can use wg-quick with this file

[danielb2]

FYI, I don't have permissions to re-open the issue

[xwang1498]

@danielb2 What does your ping command print during this scenario, or does it just stop producing output? Can you try my new branch and see if that fixes your issue? Can download the script at https://raw.githubusercontent.com/xwang1498/prettyping/refs/heads/signal-handling/prettyping . It should do a better job killing ping if it's stuck or not producing any output.

[danielb2]

does it just stop producing output

yes

Can you try my new branch and see if that fixes your issue?

yes, I tried and I can interrupt this version. nice

[xwang1498]

Great! Hopefully this fix gets merged in soon. In the meantime, my master branch has this + other improvements.

[danielb2]

just an FYI tho, yours doesn't generate the graphics properly. not sure if your branch has the same problem

[xwang1498]

Can you please share screenshots showing working vs not working graphics?

[danielb2]

[xwang1498]

It looks like you're running prettyping via macOS's /bin/sh, which is a strange way to run it. I'd suggest ./prettyping google.com or bash ./prettyping google.com.

[danielb2]

It looks like you're running prettyping via macOS's /bin/sh, which is a strange way to run it. I'd suggest ./prettyping google.com or bash ./prettyping google.com.

$ sh --version
GNU bash, version 3.2.57(1)-release (arm64-apple-darwin24)
Copyright (C) 2007 Free Software Foundation, Inc.

nothing strange about it. it's default on macos. I noticed it's a low version number tho so I tried a higher version, and that worked as expected

[xwang1498]

I believe that /bin/sh is a launcher that may or may not launch /bin/bash (bash-3.2, the last version of bash included in macOS) in posix mode, depending on your configuration. Afaik prettyping has never worked when launched in bash posix mode, and fixing that is a separate issue.