Tasks run in the wrong order

[danielfaulknor]

Describe the bug

All tasks are executed for a host before moving on to the next host, based on the order the hosts are defined, rather than doing the tasks in order. This means that pre-tasks on one host (for example generate a file and download) are happening before the host the files are needed for (upload)

To reproduce

task('do_deploy', function() {
    invoke('global:prepare');
    invoke('laravel');
    invoke('nuxt');
    invoke('queue');
    invoke('web');
    invoke('lb');
    invoke('deploy:unlock');
    invoke('cleanup');
    invoke('success');
});

task('web', function() {
    if (!get('source')) die('Source not set');
    $stage = input()->getArgument('stage');
    invoke('deploy:symlink');
    run('sudo /usr/sbin/service php7.2-fpm reload');
    run('{{bin/php}} {{release_path}}/artisan system:generate-loadbalancer-config');
    download('{{deploy_path}}/storage/haproxy/.', get('source').'/tmp', ['options' => ['--exclude=.git']]);
})->onRoles('web');

task('lb', function() {
    if (!get('source')) die('Source not set');
    $stage = input()->getArgument('stage');
    upload(get('source').'/tmp','/etc/haproxy/mapping', ['options' => ['-v -O --inplace']]);
    run('cat /etc/haproxy/mapping/* > /etc/haproxy/mapping.map');
    run('sudo /usr/sbin/service haproxy reload');
})->onRoles('lb');

If the hosts with web roles are after the hosts with the lb roles, the lb task runs first. This is just one example, there are many times this causes an issue during our deploy.

Expected behavior

Follow the order of tasks, going back and forth between hosts as required.

Environment

• Deployer version: 6.8.0
• PHP version: 7.2.33
• Deployment target(s) OS: Debian 10

[antonmedv]

Ple, attached full deploy.php and clarity what exactly order is now, and what you want to be.

[danielfaulknor]

https://gist.github.com/danielfaulknor/a3b7bbe4e81adb0c10ad1647672eaeec

with dep do_deploy test and that deploy.php, it runs task lb first, because the only host with the lb role is first in deploy.php, even though there are 5 tasks that I call from do_deploy before that one.

I want it to run each task in do_deploy over every host that is applicable before it moves onto the next task, so global:prepare and laravel run over the 2 servers with the laravel role, before it moves onto the nuxt task on the one server in that role, etc.

[antonmedv]

Still didn’t get it, please create minimal representation example. Or try to update to v7. It was redesigned and maybe solved your problem already 🤔

[danielfaulknor]

Thanks for your response! Here is a minimal example. As you can see in the task I call "first" then "second" but they run the other way around:

deploy@deploy:[~]$ cat deploy-test.php
<?php
namespace Deployer;

// Project name
set('application', 'Test');

// Hosts
host('10.99.7.31')
    ->user('envoyer')
    ->set('deploy_path', '/var/www/test')
    ->roles('second')
    ->stage('test');

host('10.99.7.21')
    ->user('envoyer')
    ->set('deploy_path', '/var/www/test')
    ->roles('first')
    ->stage('test');


task('first', function() {
  write("I should run first");
})->onRoles('first');

task('second', function() {
  write("I should run second");
})->onRoles('second');

task('deploy', function() {
    invoke('first');
    invoke('second');
});
deploy@deploy:[~]$ dep deploy -f deploy-test.php test
➤ Executing task deploy
➤ Executing task second
I should run second✔ Ok
➤ Executing task first
I should run first✔ Ok
✔ Ok
deploy@deploy:[~]$

[danielfaulknor]

I seem to be unable to build the v7 beta:

deploy@deploy:[~/deployer-7.0.0-beta.4/bin]$ ./build
PHP Parse error:  syntax error, unexpected end of file in /home/deploy/deployer-7.0.0-beta.4/bin/build on line 60
deploy@deploy:[~/deployer-7.0.0-beta.4/bin]$

[antonmedv]

You can download phar from website too.

[antonmedv]

Also try using group task instead of invoke.

[danielfaulknor]

I tried v7 and couldn't work out how to get it to work. I got stuck on setting roles on a host

For group task, it does nothing at all:

deploy@deploy:[~]$ cat deploy-test.php
<?php
namespace Deployer;

// Project name
set('application', 'Test');

// Hosts
host('10.99.7.31')
    ->user('envoyer')
    ->set('deploy_path', '/var/www/test')
    ->roles('second')
    ->stage('test');

host('10.99.7.21')
    ->user('envoyer')
    ->set('deploy_path', '/var/www/test')
    ->roles('first')
    ->stage('test');


task('first', function() {
  write("I should run first");
})->onRoles('first');

task('second', function() {
  write("I should run second");
})->onRoles('second');

task('deploy', function() {
    task('first');
    task('second');
});
deploy@deploy:[~]$ dep deploy -f deploy-test.php test
✔ Executing task deploy
deploy@deploy:[~]$

I tried using on with roles, and it runs twice for some reason:

deploy@deploy:[~]$ cat deploy-test.php
<?php
namespace Deployer;

// Project name
set('application', 'Designer Wardrobe');

// Hosts
host('10.99.7.31')
    ->user('envoyer')
    ->set('deploy_path', '/var/www/test')
    ->roles('second')
    ->stage('test');

host('10.99.7.21')
    ->user('envoyer')
    ->set('deploy_path', '/var/www/test')
    ->roles('first')
    ->stage('test');

task('first', function() {
  write("I should run first");
});

task('second', function() {
  write("I should run second");
});

task('deploy', function() {
  on(roles('first'), function ($host) {
    echo $host;
    invoke('first');
  });
  on(roles('second'), function ($host) {
    echo $host;
    invoke('second');
  });
});
deploy@deploy:[~]$ dep deploy -f deploy-test.php test
➤ Executing task deploy
envoyer@10.99.7.21➤ Executing task first
I should run first✔ Ok
envoyer@10.99.7.31➤ Executing task second
I should run second✔ Ok
envoyer@10.99.7.21➤ Executing task first
I should run first✔ Ok
envoyer@10.99.7.31➤ Executing task second
I should run second✔ Ok
✔ Ok
deploy@deploy:[~]$

[antonmedv]

Try this:

task('deploy', [
   'first',
   'second',
]);

[danielfaulknor]

Now it is ignoring onRoles on a task as in this bug #1313 which is why I was using invoke.

I tried v7 but the UPGRADING doc is incomplete

 Error  in deploy.php on line 40:

  Call to undefined method Deployer\Host\Host::roles()

[antonmedv]

Yes migration docs on it’s way. Soon will be ready