Magento 2 recipe maintenance flag in shared files

[lfolco]

Currently the Magento 2 recipe has the var/.maintenance.ip file under shared_files; should it also include var/.maintenance.flag in case the user does not specify allowed IP addresses?

[peterjaap]

Yes, good point.

[peterjaap]

Done abfb9bb

[lfolco]

Thank you!

[valguss]

Sorry to reopen this but I think this change means that any deployment will result in the site being set to maintenance mode as the .maintenance.flag file will be created if it currently doesn't exist

[peterjaap]

@lfolco you could just add it to your own config. It doesn't have to be in the core recipe. In your deploy.php, just add;

add('shared_files, ['var/.maintenance.flag']);

[valguss]

yeah, almost sounds like you just need to do:

before('deploy', 'magento:maintenance:enable');

or similar so you force into MM at the start of a deployment

[lfolco]

I'll look into a PR that does that conditionally, because otherwise the maintenance mode changes I made will no longer work.

[valguss]

aah, so basically if MM is enabled already, then you need it to persist through the deployment. Maybe do a test for .maintenance.flag in the current release:

test('[ -f {{current_path}}/var/.maintenance.flag ]');

think that'll path to the currently live version

[lfolco]

That's an idea, I'll take it for a spin. Thanks!

[peterjaap]

Reverted this change in 297e57d

[valguss]

thanks @peterjaap

[lfolco]

Please find a different way to handle this, since without that flag in shared, you cannot set maintenance mode at all when deploying.

[lfolco]

I was never able to get it to work; my site was free for all to browse when it was supposed to be in maintenance mode until we added the flag to shared.

[lfolco]

Maybe it's MageMojo's setup, I don't know. Their Stratus has been a problem since we were forced to switch to it.

[peterjaap]

That definitely sounds like it's in their setup somewhere. This has worked for us across multiple hosting providers as well as our own review environments on Google Cloud.

[valguss]

We've had Similar with Sonassi but that was because we needed to clear the opcache, so I created a separate task that sorts that out. Maybe the same here and the CacheTool recipe doesn't do it for you?

[valguss]

Ahh, that recipe should work in your case: https://magemojo.com/kb/best-practices/opcache/