--ansi sending ansi coded commands to the target

[mrhackcz]

Deployer Version

v7.5.8

Target OS

Ubuntu 24.04

Which PHP version are you using?

PHP 8.4

Content of deploy.php or deploy.yaml

desc('Restart supervisor group');
task('test:currentHost', function () {
    run('echo ' . currentHost());
});

Steps to reproduce

Hi there, I don't know if that is expected behavior. But if I wanna use currentHost() in a task, which is colored in ANSI. Deployer sends it as ANSI-coded to the target. The result is an invalid command. I think --ansi should be only printed as deployer output. But if I'm wrong, please correct me.

In task with echo It's fixable by closing currentHost() into quotation marks. But in other cases it's not that easy.

vader@deathstar:~/xxxx/xxxx/shop$ dep test:currentHost --no-ansi -vv development 
task test:currentHost
[development] run echo development
[development] development
done on development
done test:currentHost 151ms

vader@deathstar:~/xxxx/xxxx/shop$ dep test:currentHost --ansi -vv development 
task test:currentHost
[development] run echo development
[development] 
development] bash: line 1: 2: command not found
[development] bash: line 1: 115: command not found
[development] bash: line 1: 119: command not found
[development] bash: line 1: $'230mdevelopment\E[0m': command not found
[development]  error  in deploy.php on line 55:
[development] exit code 127 (Command not found)
done test:currentHost 151ms
ERROR: Task test:currentHost failed!

[antonmedv]

I did not get it.

[mrhackcz]

Yeah, sorry for my English. Which part you didn't get?

If you use --ansi the command is not only printed ansi coded, but it's also being sent to the target ansi coded like this:

--ansi
echo [38;2;115;119;230mdevelopment\e[0m

--no-ansi
echo development

As I said, it's not a problem if the command is an echo. But in my case, I am using currentHost in the task restarting supervisor group, where escaping/quotation marks won't help.

run('{{bin/supervisorctl}} restart ' . currentHost() . ':' , real_time_output: true);

--no-ansi
supervisorctl restart development:

--ansi
supervisoctl restart [38;2;115;119;230mdevelopment\e[0m

[antonmedv]

Ok, not I get the problem. If you use currentHost(), it will return Host class object. And Host object has this:

deployer/src/Host/Host.php

Lines 40 to 43 in f0320fa

	public function __toString(): string
	{
	return $this->getTag();
	}

And getTag is depended on if you use it with --ansi.

What you really what to use is hostname instead of the tag:

run('{{bin/supervisorctl}} restart {{hostname}}:');

[mrhackcz]

Ooh, ok. Thank you. {{ alias }} is what I'm looking for.