Skip to content

Commit fb524d8

Browse files
derek73claude
andcommitted
Reconcile test_brute_force (no edits needed); drop the mypy exclude
The 117-case brute-force bank passes wholesale against the facade with zero edits. With it, every v1 test file is reconciled and mypy-clean, so the TEMPORARY [tool.mypy] exclude is deleted entirely; the conftest collect_ignore_glob shrinks to its final remnant -- the two files each held on one confirmed parity bug (bound-given whole-segment join; middle_name_as_last fold order), to be deleted when those land. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent 11d9e37 commit fb524d8

2 files changed

Lines changed: 6 additions & 12 deletions

File tree

pyproject.toml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,6 @@ dev = [
4949

5050
[tool.mypy]
5151
packages = ["nameparser", "tests"]
52-
# TEMPORARY (M11 -> M12): the v1 suite is being reconciled against the
53-
# 2.0 facade; lifted with tests/conftest.py's collect_ignore_glob. Must
54-
# be gone before the branch leaves draft. tests/v2/ stays checked.
55-
exclude = '^tests/(test_(brute_force)\.py)$'
5652

5753
[[tool.mypy.overrides]]
5854
module = [

tests/conftest.py

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,12 @@
66

77
from nameparser.config import CONSTANTS
88

9-
# TEMPORARY (Task M11 -> M12): the v1 suite is being reconciled against
10-
# the 2.0 facade file by file. Lifted in Task M12 together with its mypy
11-
# twin (the `exclude` under [tool.mypy] in pyproject.toml); both must be
12-
# GONE before this branch leaves draft.
13-
#
14-
# Explicit list of not-yet-reconciled files. Narrow this as each file is
15-
# reconciled; remove entirely once the whole suite runs against the facade.
9+
# TEMPORARY (Task M12, final remnant): the whole v1 suite is reconciled
10+
# against the 2.0 facade and mypy-clean (the [tool.mypy] exclude twin in
11+
# pyproject.toml is gone). Only the two files below remain skipped, each
12+
# held on one confirmed, repro'd parity bug; delete this list (and the
13+
# entries' tests will run) once those land. Must be GONE before this
14+
# branch leaves draft.
1615
collect_ignore_glob = [
1716
# test_bound_first_names.py is reconciled (bucket A: the two
1817
# is_bound_first_name predicate tests died with the v1 hooks) but 1 test
@@ -22,7 +21,6 @@
2221
# (v1: first='abdul salam'; three-token 'salem, abdul salam ahmed'
2322
# joins fine). Remove once fixed.
2423
"test_bound_first_names.py",
25-
"test_brute_force.py",
2624
# test_middle_name_as_last.py needs NO bucket edits but 4 tests fail on
2725
# a fold-order bug: v1's middle_name_as_last fold PREPENDED middle_list
2826
# to last_list, so comma and rotated forms converge on the no-comma

0 commit comments

Comments
 (0)