Merge pull request #510 from devforth/feature/AdminForth/1326/bool-filters-doesn't-work-

fix: don't throw an error, when user tries to save 1/0 in bool field …

Author: yaroslav8765

adminforth/dataConnectors/baseConnector.ts

@@ -308,7 +308,13 @@ export default class AdminForthBaseConnector implements IAdminForthDataSourceCon
         return this.setFieldValue(field, null);
       }
       if (typeof value !== 'boolean') {
-        throw new Error(`Value is not a boolean. Field ${field.name} with type is ${field.type}, but got value: ${value} with type ${typeof value}`);
+        const errorMessage = `Value is not a boolean. Field ${field.name} with type is ${field.type}, but got value: ${value} with type ${typeof value}`;
+        if (value !== 1 && value !== 0) {
+          throw new Error(errorMessage);
+        } else {
+          afLogger.warn(errorMessage);
+          afLogger.warn(`Ignore this warn, if you are using an sqlite database`);
+        }
       }
       return this.setFieldValue(field, value);
     }

adminforth/dataConnectors/clickhouse.ts

@@ -192,7 +192,7 @@ class ClickhouseConnector extends AdminForthBaseConnector implements IAdminForth
           return iso;
         }
       } else if (field.type == AdminForthDataTypes.BOOLEAN) {
-        return  value === null ? null : (value ? 1 : 0);
+        return  value === null ? null : (value ? true : false);
       } else if (field.type == AdminForthDataTypes.JSON) {
         // check underline type is text or string
         if (field._underlineType.startsWith('String') || field._underlineType.startsWith('FixedString')) {

adminforth/dataConnectors/mysql.ts

@@ -225,7 +225,7 @@ class MysqlConnector extends AdminForthBaseConnector implements IAdminForthDataS
       }
       return dayjs(value).format('YYYY-MM-DD HH:mm:ss');
     } else if (field.type == AdminForthDataTypes.BOOLEAN) {
-      return value === null ? null : (value ? 1 : 0);
+      return value === null ? null : (value ? true : false);
     } else if (field.type == AdminForthDataTypes.JSON) {
       if (field._underlineType === 'json') {
         return value;

adminforth/dataConnectors/sqlite.ts

@@ -176,6 +176,8 @@ class SQLiteConnector extends AdminForthBaseConnector implements IAdminForthData
         }
         return JSON.stringify(value);
       } else if (field.type == AdminForthDataTypes.BOOLEAN) {
+        // SQLite does not have a native boolean type, it uses 0 and 1
+        // valid only for sqlite
         return value === null ? null : (value ? 1 : 0);
       } else if (field.type == AdminForthDataTypes.JSON) {
         // check underline type is text or string