Merge pull request #491 from devforth/feature/AdminForth/1293/find-out-why-do-we-unsubscribe

ivictbor · web-flow · commit ae600b7ab874 · 2026-03-04T23:53:20.000+02:00
fix: unsubscribe from websocket before subsribing, when we call admin…
diff --git a/adminforth/spa/src/stores/core.ts b/adminforth/spa/src/stores/core.ts
@@ -92,6 +92,7 @@ export const useCoreStore = defineStore('core', () => {
 
       // console.log('🔔 subscribeToMenuBadges', mi.badge, JSON.stringify(mi));
       if (mi.badge !== undefined) {
+        websocket.unsubscribe(`/opentopic/update-menu-badge/${mi.itemId}`);
         websocket.subscribe(`/opentopic/update-menu-badge/${mi.itemId}`, ({ badge }) => {
           mi.badge = badge;
         });
@@ -121,8 +122,6 @@ export const useCoreStore = defineStore('core', () => {
         item.badge = badge;
       }
     });
-    // TODO: This thing was created for something. Find out why
-    // websocket.unsubscribeAll();
     subscribeToMenuBadges();
 
   }

Original file line number	Diff line number	Diff line change
`@@ -92,6 +92,7 @@ export const useCoreStore = defineStore('core', () => {`
`92`	`92`
`93`	`93`	`// console.log('🔔 subscribeToMenuBadges', mi.badge, JSON.stringify(mi));`
`94`	`94`	`if (mi.badge !== undefined) {`
	`95`	+ websocket.unsubscribe(`/opentopic/update-menu-badge/${mi.itemId}`);
`95`	`96`	websocket.subscribe(`/opentopic/update-menu-badge/${mi.itemId}`, ({ badge }) => {
`96`	`97`	`mi.badge = badge;`
`97`	`98`	`});`
`@@ -121,8 +122,6 @@ export const useCoreStore = defineStore('core', () => {`
`121`	`122`	`item.badge = badge;`
`122`	`123`	`}`
`123`	`124`	`});`
`124`		`- // TODO: This thing was created for something. Find out why`
`125`		`- // websocket.unsubscribeAll();`
`126`	`125`	`subscribeToMenuBadges();`
`127`	`126`
`128`	`127`	`}`