From 5325389929b3ab97d2247f77094f3c857862d12a Mon Sep 17 00:00:00 2001 From: Timothy Mugo Date: Wed, 22 Jul 2026 20:56:31 +0300 Subject: [PATCH 1/3] fix : fix newsletter omitting some request body params --- .../src/embeddable/newsletter/index.jsx | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/packages/dvz-ui/src/embeddable/newsletter/index.jsx b/packages/dvz-ui/src/embeddable/newsletter/index.jsx index ecb6cf9a..774f0c17 100644 --- a/packages/dvz-ui/src/embeddable/newsletter/index.jsx +++ b/packages/dvz-ui/src/embeddable/newsletter/index.jsx @@ -7,14 +7,6 @@ const expresion = /^\w+([\.-]?\w+)*@\w+([\.-]?\w+)*(\.\w{2,3})+$/; const Index = (props) => { - - const submit = () => { - const list = props["data-list"]; - const tag = props["data-tag"]; - const {email} = props; - props.onSubmit({email, list, tag}) - } - const { status, editing, @@ -24,9 +16,17 @@ const Index = (props) => { "data-failure-message": failuremessage = "Something didn't go well", "data-label": label = "Send", "data-tag": tag, - email, - onChange - } = props + } = props; + + const [email, setEmail] = React.useState("") + + const submit = () => { + if (!expresion.test(email)) { + alert("Please enter a valid email address") + } + props.onSubmit({email, list, tag}) + } + let message = "" @@ -46,7 +46,7 @@ const Index = (props) => { return
onChange(target.value)} + onChange={(e, target) => setEmail(target.value)} iconPosition='left' placeholder={placeholder}/> From 3ab61aedd563a7fc179455cad845eb4b0a739764 Mon Sep 17 00:00:00 2001 From: Timothy Mugo Date: Wed, 22 Jul 2026 20:57:52 +0300 Subject: [PATCH 2/3] chore: add changeset --- .changeset/tall-groups-behave.md | 5 +++++ packages/dvz-ui/src/embeddable/newsletter/README.md | 1 - 2 files changed, 5 insertions(+), 1 deletion(-) create mode 100644 .changeset/tall-groups-behave.md diff --git a/.changeset/tall-groups-behave.md b/.changeset/tall-groups-behave.md new file mode 100644 index 00000000..d388b6a5 --- /dev/null +++ b/.changeset/tall-groups-behave.md @@ -0,0 +1,5 @@ +--- +"@devgateway/dvz-ui-react": patch +--- + +Fix newsletter request body to include the list and tag diff --git a/packages/dvz-ui/src/embeddable/newsletter/README.md b/packages/dvz-ui/src/embeddable/newsletter/README.md index 6d5d073f..62b17dc4 100644 --- a/packages/dvz-ui/src/embeddable/newsletter/README.md +++ b/packages/dvz-ui/src/embeddable/newsletter/README.md @@ -15,7 +15,6 @@ An embeddable React component that renders a Mailchimp newsletter subscription f | `successmessage` | string | `"Thanks"` | Message displayed on successful subscription | | `failuremessage` | string | `"Something didn't go well"` | Message displayed on failed subscription | | `editing` | boolean | — | When truthy, shows both success and error messages simultaneously (editor preview) | -| `email` *(Redux)* | string | — | Current email input value (managed via Redux store) | | `status` *(Redux)* | string | — | Subscription status: `"OK"` or `"ERROR"` | ## Usage Example From 9de6d7ebaae35e410e515831dcac5520b035e98a Mon Sep 17 00:00:00 2001 From: Timothy Mugo Gachengo <55899373+timothygachengo@users.noreply.github.com> Date: Thu, 23 Jul 2026 07:31:50 +0300 Subject: [PATCH 3/3] Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- packages/dvz-ui/src/embeddable/newsletter/index.jsx | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/dvz-ui/src/embeddable/newsletter/index.jsx b/packages/dvz-ui/src/embeddable/newsletter/index.jsx index 774f0c17..e2b5703f 100644 --- a/packages/dvz-ui/src/embeddable/newsletter/index.jsx +++ b/packages/dvz-ui/src/embeddable/newsletter/index.jsx @@ -21,9 +21,7 @@ const Index = (props) => { const [email, setEmail] = React.useState("") const submit = () => { - if (!expresion.test(email)) { - alert("Please enter a valid email address") - } + if (!expresion.test(email)) return props.onSubmit({email, list, tag}) }