Commit 2a29125
committed
fix: drop bogus Incidents.delete and add StatusPages.reorder_layout
Two surface-parity gaps surfaced by `tests/surfaces/parity/`:
1. **Drop `Incidents.delete()`** — the underlying API endpoint
`DELETE /api/v1/incidents/{id}` does not exist; calling this method
would always return a 404. The method was a leftover from earlier API
experimentation and was missing from sdk-js / mcp-server / cli, so the
parity check (rightly) flagged sdk-python as out of sync. Removing it
here is the canonical decision: incidents are auto-resolved or manually
resolved via `incidents.resolve(...)`, never deleted.
This is technically a breaking change to the `devhelm` Python package
public API, but no real consumers exist (the method has never produced
a successful response). Captured in the version bump for the next
release.
2. **Add `StatusPages.reorder_layout(id, body)`** — hits the existing
`PUT /api/v1/status-pages/{id}/layout/reorder` endpoint, mirroring
`sdk-js.StatusPages.reorderLayout`. Wires through the
`ReorderPageLayoutRequest` model (already in `_generated.py`); also
re-exports it from the top-level `devhelm` package and `devhelm.types`,
plus a harness entry for the surface-test suite.
Synced uv.lock to match `devhelm` 0.2.0 already in pyproject.toml.
Verified locally:
- `pytest tests/` — 707 passed
- `mypy src/` — clean
- `ruff format` / `ruff check` — clean
- `make test-surface SURFACE=sdk_python` (against test API) — 174 passed,
1 skipped
Made-with: Cursor1 parent be03beb commit 2a29125
6 files changed
Lines changed: 26 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
| 85 | + | |
85 | 86 | | |
86 | 87 | | |
87 | 88 | | |
| |||
204 | 205 | | |
205 | 206 | | |
206 | 207 | | |
| 208 | + | |
207 | 209 | | |
208 | 210 | | |
209 | 211 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
| |||
392 | 393 | | |
393 | 394 | | |
394 | 395 | | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
| 84 | + | |
84 | 85 | | |
85 | 86 | | |
86 | 87 | | |
| |||
250 | 251 | | |
251 | 252 | | |
252 | 253 | | |
| 254 | + | |
253 | 255 | | |
254 | 256 | | |
255 | 257 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| 42 | + | |
42 | 43 | | |
43 | 44 | | |
44 | 45 | | |
| |||
137 | 138 | | |
138 | 139 | | |
139 | 140 | | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | 141 | | |
144 | 142 | | |
145 | 143 | | |
| |||
311 | 309 | | |
312 | 310 | | |
313 | 311 | | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
314 | 317 | | |
315 | 318 | | |
316 | 319 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments