Fix startup profile chooser default handling

Author: devnullvoid

CHANGELOG.md

@@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - **Ansible Toolkit Plugin**: Added a new opt-in `ansible` plugin with integrated toolkit workflows for generating inventory from loaded Proxmox nodes/guests (YAML or INI, compact/expanded styles, optional custom `inventory_vars`), previewing/saving inventory, running `ansible -m ping`, executing `ansible-playbook` with reusable form state, and providing an SSH setup guide. Includes plugin settings for default user/password/key path, limit behavior, and default Ansible extra arguments.
 
+### Fixed
+
+- **Startup Profile Chooser Default Handling**: When `default_profile` is unset, startup now correctly prompts for profile/group selection even if a profile is literally named `default`, and non-interactive launches now return a clear error instead of exiting successfully without starting the app.
+
 ## [1.0.20] - 2026-02-28
 
 ### Added

internal/bootstrap/bootstrap.go

@@ -7,6 +7,7 @@ package bootstrap
 
 import (
 	"bufio"
+	"errors"
 	"flag"
 	"fmt"
 	"os"
@@ -62,6 +63,8 @@ type BootstrapResult struct {
 	InitialGroup string
 }
 
+var errSelectionCanceled = errors.New("profile selection canceled")
+
 // ParseFlags parses command line flags and returns bootstrap options.
 func ParseFlags() BootstrapOptions {
 	var configPath, profile string
@@ -262,8 +265,7 @@ func Bootstrap(opts BootstrapOptions) (*BootstrapResult, error) {
 		} else {
 			chosen, err := promptProfileSelection(cfg)
 			if err != nil {
-				fmt.Println("🚪 Exiting.")
-				os.Exit(0)
+				return nil, fmt.Errorf("interactive profile selection failed: %w", err)
 			}
 			selectedProfile = chosen
 		}
@@ -629,6 +631,11 @@ func valueOrDash(value string) string {
 // It returns the selected profile or group name, or an error if the user
 // cancels or no valid input is provided.
 func promptProfileSelection(cfg *config.Config) (string, error) {
+	stat, err := os.Stdin.Stat()
+	if err != nil || stat.Mode()&os.ModeCharDevice == 0 {
+		return "", fmt.Errorf("%w: no interactive terminal available", errSelectionCanceled)
+	}
+
 	// Collect groups (sorted)
 	groups := cfg.GetGroups()
 	groupNames := make([]string, 0, len(groups))
@@ -696,7 +703,7 @@ func promptProfileSelection(cfg *config.Config) (string, error) {
 		if !scanner.Scan() {
 			// EOF or Ctrl+C
 			fmt.Println()
-			return "", fmt.Errorf("selection canceled")
+			return "", errSelectionCanceled
 		}
 		line := strings.TrimSpace(scanner.Text())
 		n, err := strconv.Atoi(line)

internal/bootstrap/bootstrap_test.go

@@ -1,6 +1,7 @@
 package bootstrap
 
 import (
+	"errors"
 	"os"
 	"path/filepath"
 	"strings"
@@ -100,3 +101,56 @@ func TestFormatProfileAndGroupListNoProfiles(t *testing.T) {
 		t.Fatalf("expected empty selected value in output: %q", output)
 	}
 }
+
+func TestPromptProfileSelectionRequiresInteractiveTerminal(t *testing.T) {
+	t.Setenv("PVETUI_PROFILE", "")
+
+	cfg := &config.Config{
+		Profiles: map[string]config.ProfileConfig{
+			"dev": {
+				Addr: "https://dev.example",
+				User: "root@pam",
+			},
+			"prod": {
+				Addr: "https://prod.example",
+				User: "root@pam",
+			},
+		},
+	}
+
+	_, err := promptProfileSelection(cfg)
+	if !errors.Is(err, errSelectionCanceled) {
+		t.Fatalf("expected errSelectionCanceled, got %v", err)
+	}
+	if err == nil {
+		t.Fatal("expected selection cancellation error")
+	}
+}
+
+func TestBootstrapReturnsErrorWhenSelectionNeedsTTY(t *testing.T) {
+	configPath := filepath.Join(t.TempDir(), "config.yaml")
+	configData := `profiles:
+  dev:
+    addr: https://dev.example
+    user: root@pam
+    password: secret
+  prod:
+    addr: https://prod.example
+    user: root@pam
+    password: secret
+`
+	if err := os.WriteFile(configPath, []byte(configData), 0o600); err != nil {
+		t.Fatalf("write config: %v", err)
+	}
+
+	result, err := Bootstrap(BootstrapOptions{ConfigPath: configPath})
+	if result != nil {
+		t.Fatalf("expected nil result when bootstrap cannot prompt, got %+v", result)
+	}
+	if err == nil {
+		t.Fatal("expected bootstrap error when no interactive terminal is available")
+	}
+	if !strings.Contains(err.Error(), "interactive profile selection failed") {
+		t.Fatalf("expected interactive selection error, got %v", err)
+	}
+}

internal/config/config.go

@@ -330,8 +330,7 @@ func ValidateKeyBindings(kb KeyBindings) error {
 //	}
 func NewConfig() *Config {
 	config := &Config{
-		Profiles:       make(map[string]ProfileConfig),
-		DefaultProfile: "default",
+		Profiles: make(map[string]ProfileConfig),
 		// Read environment variables for legacy fields
 		Addr:        os.Getenv("PVETUI_ADDR"),
 		User:        os.Getenv("PVETUI_USER"),
@@ -1243,8 +1242,8 @@ func (c *Config) SetDefaults() {
 		c.Plugins.Ansible.Bootstrap.SSHPublicKeyFile = ExpandHomePath(c.Plugins.Ansible.Bootstrap.SSHPublicKeyFile)
 	}
 
-	// ShowIcons defaults to true (icons enabled)
-	// No explicit default needed since it's already set in NewConfig()
+	// ShowIcons defaults to true (icons enabled).
+	// The zero value is treated as enabled unless explicitly set to false by env/config.
 }
 
 // ExpandHomePath expands a leading ~ in paths using the current user's home directory.

internal/config/config_test.go

@@ -678,6 +678,12 @@ func TestConfig_SetDefaults(t *testing.T) {
 	assert.Equal(t, "Ctrl+f", config.KeyBindings.AdvancedGuestFilter)
 }
 
+func TestNewConfigDoesNotSeedDefaultProfile(t *testing.T) {
+	cfg := NewConfig()
+
+	assert.Empty(t, cfg.DefaultProfile)
+}
+
 func TestConfig_MergeWithFile_AdvancedGuestFilterBinding(t *testing.T) {
 	tempFile, err := os.CreateTemp("", "config-advanced-filter-key-*.yaml")
 	require.NoError(t, err)

internal/ui/components/refresh.go

@@ -151,20 +151,9 @@ func (a *App) doManualRefresh(token uint64) {
 	}()
 }
 
-// fastRefresh loads basic node/VM names immediately and enriches details in the background.
-// This is the public entry point; it acquires the refresh guard and delegates to doFastRefresh.
-// Used for normal fast-refresh (failover callbacks, etc.) where a refresh may already be running.
-func (a *App) fastRefresh() {
-	token, ok := a.startRefresh()
-	if !ok {
-		return
-	}
-	a.doFastRefresh(token)
-}
-
 // doFastRefresh is the implementation of fast refresh.
 // Callers that already hold a generation token (e.g. profile switches via forceNewRefresh)
-// should call this directly instead of fastRefresh.
+// should call this directly instead of acquiring a new token first.
 // This is used for profile switching where perceived speed matters most —
 // the user sees node and guest lists right away, then details (CPU, filesystems, guest agent)
 // fill in progressively.