Commit 94d2fa4
refactor(writer): drop dead ptype arms in primitiveArrayLen
All three callers (the global-dict writer's two chunk loops and the
isDictCandidate check, which runs after its narrow-int/F16/F32 early
return) pass only dict-admitted ptypes: I32/U32, I64/U64, F64. The
I8/U8, I16/U16/F16, and F32 arms were unreachable dead code. Collapse
to default -> throw and retarget the unit test's artificial I8 case to
F64.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>1 parent f89072a commit 94d2fa4
2 files changed
Lines changed: 5 additions & 4 deletions
File tree
- writer/src
- main/java/io/github/dfa1/vortex/writer
- test/java/io/github/dfa1/vortex/writer
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1321 | 1321 | | |
1322 | 1322 | | |
1323 | 1323 | | |
| 1324 | + | |
| 1325 | + | |
1324 | 1326 | | |
1325 | 1327 | | |
1326 | | - | |
1327 | | - | |
1328 | 1328 | | |
1329 | 1329 | | |
1330 | | - | |
1331 | 1330 | | |
| 1331 | + | |
1332 | 1332 | | |
1333 | 1333 | | |
1334 | 1334 | | |
| |||
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
| 103 | + | |
103 | 104 | | |
104 | 105 | | |
105 | 106 | | |
106 | | - | |
| 107 | + | |
107 | 108 | | |
108 | 109 | | |
109 | 110 | | |
| |||
0 commit comments