From bf78756a514ea7e4d59669ac6cc25e7cb5995ec2 Mon Sep 17 00:00:00 2001 From: Birk Johansson Date: Sun, 18 Sep 2022 15:51:35 +0200 Subject: [PATCH 1/3] fix(cell): fix synced background for highlighted cell --- src/data-workspace/data-entry-cell/data-entry-cell.module.css | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/data-workspace/data-entry-cell/data-entry-cell.module.css b/src/data-workspace/data-entry-cell/data-entry-cell.module.css index ae5603d8d5..9a6c8725c7 100644 --- a/src/data-workspace/data-entry-cell/data-entry-cell.module.css +++ b/src/data-workspace/data-entry-cell/data-entry-cell.module.css @@ -27,7 +27,9 @@ .highlighted { outline: 3px solid var(--colors-grey800) !important; border: none !important; - background: #fff !important; + background: #fff; + /* Fix to prevent bottom outline to be clipped by next cell*/ + z-index: 1; } .highlighted.active { From 356ea98743112eb1a6ca0c212f83a0f1bc22fc10 Mon Sep 17 00:00:00 2001 From: Birk Johansson Date: Sun, 18 Sep 2022 16:20:09 +0200 Subject: [PATCH 2/3] fix: fix highlighted styling --- .../data-entry-cell/data-entry-cell.module.css | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/data-workspace/data-entry-cell/data-entry-cell.module.css b/src/data-workspace/data-entry-cell/data-entry-cell.module.css index 9a6c8725c7..b28e2a6cb4 100644 --- a/src/data-workspace/data-entry-cell/data-entry-cell.module.css +++ b/src/data-workspace/data-entry-cell/data-entry-cell.module.css @@ -24,6 +24,10 @@ outline: 1px solid #a0adba; } +.active { + background-color: #fff !important; +} + .highlighted { outline: 3px solid var(--colors-grey800) !important; border: none !important; @@ -32,6 +36,7 @@ z-index: 1; } + .highlighted.active { outline-color: var(--theme-focus) !important; } @@ -40,10 +45,11 @@ background: var(--colors-grey300); } -.invalid:not(.highlighted) { +.invalid:not(.active) { background: var(--colors-red200); - outline: 1px solid var(--colors-red600) !important; + outline: 1px solid var(--colors-red600); } + .invalid:hover { background: #ffb3bc; } From a20f882699faa17ca89265c9656e424b814e5230 Mon Sep 17 00:00:00 2001 From: Birk Johansson Date: Mon, 19 Sep 2022 09:05:31 +0200 Subject: [PATCH 3/3] fix: minor cleanup --- src/data-workspace/data-entry-cell/data-entry-cell.module.css | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/data-workspace/data-entry-cell/data-entry-cell.module.css b/src/data-workspace/data-entry-cell/data-entry-cell.module.css index b28e2a6cb4..bf11c64b8c 100644 --- a/src/data-workspace/data-entry-cell/data-entry-cell.module.css +++ b/src/data-workspace/data-entry-cell/data-entry-cell.module.css @@ -31,8 +31,7 @@ .highlighted { outline: 3px solid var(--colors-grey800) !important; border: none !important; - background: #fff; - /* Fix to prevent bottom outline to be clipped by next cell*/ + /* Fix to prevent bottom outline to be clipped by next cell */ z-index: 1; }