Skip to content
This repository was archived by the owner on Dec 30, 2024. It is now read-only.
This repository was archived by the owner on Dec 30, 2024. It is now read-only.

make customization easier #62

@mahmoudbahaa

Description

@mahmoudbahaa

it is not actually a bug but a request

in XMLHTTPServiceProvider urlSuffix & serializer are declared protected

protected var urlSuffix:String;

protected var serializer:ISerializer;

so one needs to subclass to modify them if they were declared public or had setter it would make changing them easier for those who want to use for example standard xml format instead of fxml or want to use a customized serializer

Also in XML serializer ID need to be give as a child tag of the node but sometimes it is given as an attribute instead so changing

var node:XML = XML(source);
.....
var nodeId:String = node.id;
.....

to

var node:XML = XML(source);
.....
var nodeId:String = node.id;
if(!nodeId)
      node.attribute("id");
.....

would make it more adoptable

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions