Skip to content

minor -- fix type hint for update_rating method #18

@djcunningham0

Description

@djcunningham0

Very minor, but the type hint should be updated for the date parameter in Player.update_rating. It can be pretty much any value that can be sorted (e.g., datetime objects), not just floats or strings.

def update_rating(self, new_rating: float, date: Union[str, float], keep_history: bool = True):

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions