Possibility of bringing downstream changes to upstream repo

[eott-siz]

First of all, thank you very much for creating Streamlit Flow! It has saved us quite a bit of work creating a little app for internal use.

As we are supporting only one specific app using the framework, we have decided to implement any required changes in a fork. I want to take the opportunity to discuss if, in the long term, these changes might be brought upstream so others can use them too. This will probably have to be discussed for each feature, so the canonical repository doesn't become bloated with features only a few users need.

At the moment we have two features that differ from upstream. More will probably follow in the future:

1. Added an argument to the streamlit_flow function/class to carry default edge options to the frontend. This was useful so edges can be set to be deletable by default.
2. Implemented multiple handles on nodes. This feature still needs some work, as it breaks easily when editing nodes and edges.

[adamzacharia]

Hi, Can I get access to your version because I was also trying to implement multiple handles on nodes.

[tommattgeorge]

@eott-siz How did you get the multiple handles on nodes to work? @adamzacharia and I were trying to define a new source- sourcePosition2- but that won't work because ReactFlow has sourcePosition already defined in it, so we can't just define our own new sources/targets.

[eott-siz]

@tommattgeorge We maintain the fork at https://github.com/siz-energieplus/streamlit-flow

As said, the feature is not fully developed yet, as I noticed some problems when nodes and edges are deleted. The initial approach extended the MarkdownNode function with additional arguments, but it proved tricky to transfer the required user input into the arguments as some functionality lies within ReactFlow and can't be easily changed within the frontend part of StreamlitFlow. The current approach transfers additional data in the data argument, which can be setup to contain pretty much anything. This implementation also uses a single source/target position for all source/target handles (that is our use case), but it should be relatively straightforward to extend that so every handle can have its position individually specified.

[BirdBare]

I have made an attempt to add multiple handles as well. Mine is much more flexible and should be thought of as a foundational rework. https://github.com/BirdBare/streamlit-flow