Doing does not permit code to be merged into the master branch unless it has been submitted as a Pull Request.
All Pull Requests must be reviewed by one of your peers before it can be merged into master.
- You have read and understand Doing's Coding Culture
- You are working off a git branch named after a corresponding Sprintly ticket
- You have merged in the latest master branch and resolved all merge conflicts
- Commit and push your Sprintly ticket branch using Smart Commit messages
- Visit your project's repo on Github and click Compare & pull request
- Add a Title that briefly explains the PR
- Use the text from our Pull Request Template as the base of your PR comment
- Update the PR comment to complete as much information as you can provide
- Add a Label of Ready for Code Review
- Click Create pull request
- One your new PR, click the checkbox under PR Author to indicate you have completed that task
- Use HipChat to notify your peers that you have a PR that needs review
- Watch for PR notifications and address any concerns raised by your peers
- Visit the PR you are being asked to review
- Before starting your PR Review, remove the Label Ready for Review and add the Label In Code Review
- Review the Files changed tab and add any inline comments ( click line number ) you have feedback with
- Add any overall feedback as a new comment on the main Conversation tab
- Once code review is complete, check off the items in the PR Reviewer once you have completed them
- If the PR fails, remove the Label In Code Review and select a new label showing what action is needed
- If the PR Passes, remove all Labels and click Merge pull request
- If you are 100% certain you will never need that branch again, you can delete the branch after merging into master
- Contact the PR Author and let them know the results of your review
- Stay on top of any PR's you are reviewing until they are able to be successfully merged into master