createBundle crashes running game and editor

[AdrianJMartin]

I suspect its in the factory lambda...tested by commenting out the the code in .doriax and running, button event then no longer crashes out, but obviously does not rehydrate the package

button in ui sub scene....

button_aScript::button_aScript(Scene *scene, Entity entity) : Button(scene, entity)
{
    REGISTER_ENGINE_EVENT(onUpdate);

    getComponent<ButtonComponent>()
        .onPress
        .add("pressed", [&]()
             {

                 Log::print("Button pressed!");

                 for (auto bundleName : BundleManager::getBundleNames())
                 {
                     Log::print(bundleName.c_str());
                 }

                 
                 auto main_scene = Engine::getMainScene();
                 Entity falling_block_root = main_scene->findEntity("falling_block_root");
                 
                 std::stringstream ss;
                 ss << "Entity: " << falling_block_root;
                 Log::print( ss.str().c_str() );

                 auto e = BundleManager::createBundle( "falling_block" , scene  , falling_block_root);
                 
                 ss.str("");
                 ss << "Entity: " << falling_block_root;
                 Log::print( ss.str().c_str() );

             });
}

[eduardodoria]

I am checking

[eduardodoria]

The crash was real and I think I fixed it.

Two problems in the button script. The lambda captures with [&], so scene (a constructor parameter) is a dangling reference by the time onPress fires. And scene is the UI sub-scene, while falling_block_root lives on the main scene. Entity IDs are per-scene and both scenes start at 1001, so that id resolves to whatever UI entity happens to share the number.

Now, you can use createBundle(name, scene, rootName) that resolves the root by name inside that scene, so a UI script cannot target a same-numbered UI entity by accident.

getComponent<ButtonComponent>().onPress.add("pressed", [this]() {
    BundleManager::createBundle("falling_block", Engine::getMainScene(), "falling_block_root");
 });

Other thing you can do is drag and drop an entity of any scene or child scene to a script (in case o C++ need to be the header), so a DPROPERTY with this entity is created and you can use in your script.

[AdrianJMartin]

ah... sorry scene / main_scene muddle up was my fault! Obvious now I look at the code again!

the call:
BundleManager::createBundle("falling_block", Engine::getMainScene(), "falling_block_root");
is now replacing 'falling_block_root'...but when the scene exits it is removed from the scene, not just the spawned bundle.
Pressing the button, several times logs the message "[Error] BundleManager: root entity 1008 already has a bundle instance in this scene"

the 'falling_block_root' object is completely removed from the scene - I have to manually add it back to the scene via the editor

start the scene with falling_block_root in place

falling block is spawn underneath not as a child of falling_block_root

Stopping the scene removes the spawned block

Running again and pressing the button, replaces the falling_block_root!

Stopping the scene, REMOVEs the falling_block_root entirely

[eduardodoria]

Almost all the issues here (that I was able to reproduce) have been fixed. The "[Error] BundleManager: root entity 1008 already has a bundle instance in this scene" situation remains. This is actually a design issue. It really doesn't allow creating more than one instance with the same root. I'm thinking the best way to resolve this.

To work around it, you can do this:

getComponent<ButtonComponent>().onPress.add("pressed", [this]() {
    Scene* scene = Engine::getMainScene();
    Entity block = BundleManager::createBundle("falling_block", scene);

    // optional: keep them tidy under the existing holder entity
    Object holder(scene, scene->findEntity("falling_block_root"));
    holder.addChild(block);
});

However, I realize this isn't the ideal approach, so I'll think of a better solution.

[eduardodoria]

I’ve changed the behavior of createBundle. The parameter is no longer called root, but rather parent. The bundle's root is now always created automatically. You can specify the parent within the hierarchy, allowing you to create as many instances as you like.

I think this aligns better with how other engines handle it.

Before run

During run and after clicked button multiple times