Commit f19c1fc
authored
[xabt] Fix
Add '$(RunILLink)' != 'false' to the Condition of _TouchAndroidLinkFlag
so it Condition-skips in lockstep with the ILLink target it hooks via
AfterTargets. This works around an MSBuild behavior (dotnet/msbuild#13274)
where AfterTargets hooks may fire before the target actually executes,
leading to a stale flag.
Without this fix, _TouchAndroidLinkFlag's Inputs/Outputs check sees
stale timestamps on the first (skipped) ILLink invocation and skips
itself, then never runs again when ILLink actually executes. This
can sometimes cause link.flag to go stale, which can cause
_RemoveRegisterAttribute and the AssemblyModifierPipeline to skip on
incremental builds._TouchAndroidLinkFlag target skipping on NativeAOT incremental builds (#10849)1 parent a040a1d commit f19c1fc
File tree
1 file changed
+1
-1
lines changed- src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets
1 file changed
+1
-1
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
243 | 243 | | |
244 | 244 | | |
245 | 245 | | |
246 | | - | |
| 246 | + | |
247 | 247 | | |
248 | 248 | | |
249 | 249 | | |
| |||
0 commit comments