Skip to content

Commit 04c3c67

Browse files
T-GroCopilot
andcommitted
Fix CI: add release notes, fix issue references, clean spurious neg06.bsl duplicates
- Add release notes entry for narrowed FS0041 error range (#14284) - Fix wrong issue references from #14190 to #14284 in source and tests - Remove spurious duplicate FS0954/FS0953 errors from neg06.bsl baseline (only the FS0041 range change belongs to this PR) - Rebase onto latest main Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent fd80bda commit 04c3c67

4 files changed

Lines changed: 7 additions & 36 deletions

File tree

docs/release-notes/.FSharp.Compiler.Service/11.0.100.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
### Fixed
22

3+
* Narrow 'No overloads match for method' error range to method name only instead of covering the entire expression. ([Issue #14284](https://github.com/dotnet/fsharp/issues/14284), [PR #19505](https://github.com/dotnet/fsharp/pull/19505))
34
* Fix DU case names matching IWSAM member names no longer cause duplicate property entries. (Issue [#14321](https://github.com/dotnet/fsharp/issues/14321), [PR #19341](https://github.com/dotnet/fsharp/pull/19341))
45
* Fix DefaultAugmentation(false) duplicate entry in method table. (Issue [#16565](https://github.com/dotnet/fsharp/issues/16565), [PR #19341](https://github.com/dotnet/fsharp/pull/19341))
56
* Fix abstract event accessors now have SpecialName flag. (Issue [#5834](https://github.com/dotnet/fsharp/issues/5834), [PR #19341](https://github.com/dotnet/fsharp/pull/19341))

src/Compiler/Checking/Expressions/CheckExpressions.fs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10404,7 +10404,7 @@ and TcMethodApplication
1040410404
// Narrow the error range for unresolved overloading from the whole expression (mMethExpr)
1040510405
// to just the method name. For instance calls like T.Instance.Method(""), mItem covers
1040610406
// the entire "T.Instance.Method" range, so we compute the method-name-only range from
10407-
// the end of mItem and the method name length. See https://github.com/dotnet/fsharp/issues/14190.
10407+
// the end of mItem and the method name length. See https://github.com/dotnet/fsharp/issues/14284.
1040810408
let errors =
1040910409
match errors with
1041010410
| ErrorResult(warns, UnresolvedOverloading(denvErr, callerArgsErr, failure, _mWide)) ->

tests/FSharp.Compiler.ComponentTests/ErrorMessages/OverloadResolutionErrorRangeTests.fs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ module ErrorMessages.OverloadResolutionErrorRangeTests
33
open Xunit
44
open FSharp.Test.Compiler
55

6-
// https://github.com/dotnet/fsharp/issues/14190
6+
// https://github.com/dotnet/fsharp/issues/14284
77
[<Fact>]
8-
let ``Issue 14190 - overload error should cover only method name, not full expression`` () =
8+
let ``Issue 14284 - overload error should cover only method name, not full expression`` () =
99
FSharp
1010
"""
1111
type T() =
@@ -29,7 +29,7 @@ Available overloads:
2929

3030
// Verify that the error range is narrow also for simple direct method calls
3131
[<Fact>]
32-
let ``Issue 14190 - overload error for simple static method`` () =
32+
let ``Issue 14284 - overload error for simple static method`` () =
3333
FSharp
3434
"""
3535
type T() =
@@ -51,7 +51,7 @@ Available overloads:
5151

5252
// Verify that a long expression before the method doesn't widen the error range
5353
[<Fact>]
54-
let ``Issue 14190 - overload error on chained expression`` () =
54+
let ``Issue 14284 - overload error on chained expression`` () =
5555
FSharp
5656
"""
5757
type T() =
@@ -76,7 +76,7 @@ Available overloads:
7676

7777
// Verify error range with lambda argument
7878
[<Fact>]
79-
let ``Issue 14190 - overload error with lambda argument`` () =
79+
let ``Issue 14284 - overload error with lambda argument`` () =
8080
FSharp
8181
"""
8282
type T() =

tests/fsharp/typecheck/sigs/neg06.bsl

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -16,30 +16,16 @@ neg06.fs(37,6,37,29): typecheck error FS0954: This type definition involves an i
1616

1717
neg06.fs(37,6,37,29): typecheck error FS0912: This declaration element is not permitted in an augmentation
1818

19-
neg06.fs(37,6,37,29): typecheck error FS0954: This type definition involves an immediate cyclic reference through a struct field or inheritance relation
20-
2119
neg06.fs(42,6,42,30): typecheck error FS0954: This type definition involves an immediate cyclic reference through a struct field or inheritance relation
2220

2321
neg06.fs(46,5,46,29): typecheck error FS0954: This type definition involves an immediate cyclic reference through a struct field or inheritance relation
2422

2523
neg06.fs(42,6,42,30): typecheck error FS0912: This declaration element is not permitted in an augmentation
2624

27-
neg06.fs(42,6,42,30): typecheck error FS0954: This type definition involves an immediate cyclic reference through a struct field or inheritance relation
28-
29-
neg06.fs(46,5,46,29): typecheck error FS0954: This type definition involves an immediate cyclic reference through a struct field or inheritance relation
30-
3125
neg06.fs(53,10,53,19): typecheck error FS0954: This type definition involves an immediate cyclic reference through a struct field or inheritance relation
3226

3327
neg06.fs(60,10,60,20): typecheck error FS0954: This type definition involves an immediate cyclic reference through a struct field or inheritance relation
3428

35-
neg06.fs(60,10,60,20): typecheck error FS0954: This type definition involves an immediate cyclic reference through a struct field or inheritance relation
36-
37-
neg06.fs(60,10,60,20): typecheck error FS0954: This type definition involves an immediate cyclic reference through a struct field or inheritance relation
38-
39-
neg06.fs(64,9,64,19): typecheck error FS0954: This type definition involves an immediate cyclic reference through a struct field or inheritance relation
40-
41-
neg06.fs(64,9,64,19): typecheck error FS0954: This type definition involves an immediate cyclic reference through a struct field or inheritance relation
42-
4329
neg06.fs(64,9,64,19): typecheck error FS0954: This type definition involves an immediate cyclic reference through a struct field or inheritance relation
4430

4531
neg06.fs(75,10,75,19): typecheck error FS0954: This type definition involves an immediate cyclic reference through a struct field or inheritance relation
@@ -48,8 +34,6 @@ neg06.fs(80,10,80,25): typecheck error FS0953: This type definition involves an
4834

4935
neg06.fs(90,10,90,11): typecheck error FS0953: This type definition involves an immediate cyclic reference through an abbreviation
5036

51-
neg06.fs(90,10,90,11): typecheck error FS0953: This type definition involves an immediate cyclic reference through an abbreviation
52-
5337
neg06.fs(94,10,94,11): typecheck error FS0953: This type definition involves an immediate cyclic reference through an abbreviation
5438

5539
neg06.fs(99,10,99,11): typecheck error FS0953: This type definition involves an immediate cyclic reference through an abbreviation
@@ -58,26 +42,12 @@ neg06.fs(100,9,100,10): typecheck error FS0035: This construct is deprecated: Th
5842

5943
neg06.fs(104,10,104,11): typecheck error FS0953: This type definition involves an immediate cyclic reference through an abbreviation
6044

61-
neg06.fs(104,10,104,11): typecheck error FS0953: This type definition involves an immediate cyclic reference through an abbreviation
62-
63-
neg06.fs(108,10,108,11): typecheck error FS0953: This type definition involves an immediate cyclic reference through an abbreviation
64-
6545
neg06.fs(108,10,108,11): typecheck error FS0953: This type definition involves an immediate cyclic reference through an abbreviation
6646

6747
neg06.fs(112,10,112,11): typecheck error FS0953: This type definition involves an immediate cyclic reference through an abbreviation
6848

6949
neg06.fs(117,10,117,11): typecheck error FS0953: This type definition involves an immediate cyclic reference through an abbreviation
7050

71-
neg06.fs(117,10,117,11): typecheck error FS0953: This type definition involves an immediate cyclic reference through an abbreviation
72-
73-
neg06.fs(117,10,117,11): typecheck error FS0953: This type definition involves an immediate cyclic reference through an abbreviation
74-
75-
neg06.fs(118,9,118,10): typecheck error FS0953: This type definition involves an immediate cyclic reference through an abbreviation
76-
77-
neg06.fs(118,9,118,10): typecheck error FS0953: This type definition involves an immediate cyclic reference through an abbreviation
78-
79-
neg06.fs(118,9,118,10): typecheck error FS0953: This type definition involves an immediate cyclic reference through an abbreviation
80-
8151
neg06.fs(118,9,118,10): typecheck error FS0953: This type definition involves an immediate cyclic reference through an abbreviation
8252

8353
neg06.fs(118,9,118,10): typecheck error FS0035: This construct is deprecated: This type abbreviation has one or more declared type parameters that do not appear in the type being abbreviated. Type abbreviations must use all declared type parameters in the type being abbreviated. Consider removing one or more type parameters, or use a concrete type definition that wraps an underlying type, such as 'type C<'a> = C of ...'.

0 commit comments

Comments
 (0)