Consider renaming COM* types in clr native code to CLR*

[huoyaoyuan]

Currently, there are still some native code elements named with COM prefix from the COM+ era, like COMFloat and COMDouble:

runtime/src/coreclr/classlibnative/inc/floatdouble.h

Line 10 in a5d13e2

class COMDouble {

Can we rename them to things like CLRDouble, to make a clear distinction with COM interop? Are there any tools depending on these names?

[AaronRobinsonMSFT]

Are there any tools depending on these names?

There is no reason these can't be changed. Good suggestion.

[AaronRobinsonMSFT]

If someone wants to take this up, it would be most appropriate to provide a list of the types and APIs that will be updated.

[jkotas]

Most of these COM* types are holding types for FCalls. The newer naming convention is to use Native suffix. For example, AssemblyNative, MarshalNative, ObjectNative, StreamNative, ... .

Also, we may want to change FCalls to be extern "C" methods, similar to what we have done with QCalls a while back in #60992. It would set us up for convergence with native AOT. FCalls in native AOT have to be extern "C" methods to enable linking managed code with unmanaged runtime using platform linker.

[huoyaoyuan]

A list of symbols that can be renamed at my site of view:

COM interop related:
ComPlusCall -> ClrToComCall (the file has been renamed)
ComPlusCallInfo
ComPlusCallMethodDesc etc. Remove the "ComPlus" name.

FCall related:
COMDateTime
COMDelegate
comdependenthandle.h
comdynamic.h (QCall)
COMModule
COMSynchronizable.h
comthreadpool.h
comwaithandle.h
COMCustomAttribute
COMString
gCOM*Funcs in ecalllist.h
COMDouble
COMSingle
COMVariant
COMOAVariant
COMInterlocked

Macros:
COMPlusThrow seires

[AaronRobinsonMSFT]

Thanks @huoyaoyuan

A list of symbols that can be renamed at my site of view:

From that list, the FCall related changes have a mix of real COM interop and just legacy naming. The COM interop related will need some more scrutiny. The exception macros can be changed for sure.

The COMVariant, COMOAVariant, ComAwareWeakReferenceNative and COMDateTime are a bit tricky for now and a mix of real COM types/specifications and just general .NET code. They should be left alone in this initial effort.

[Giviruk]

can I try to do this issue? do I just need to rename the types from the list or something else?

[AaronRobinsonMSFT]

@Giviruk Sure. Please note the guidance from #86145 (comment).

[huoyaoyuan]

I'd suggest to go with less types at a time, and exclude ones when you feel it's too complex. You can start with searching the usages.

[pierrebelin]

can I try to do this issue? do I just need to rename the types from the list or something else?

I'd like to work on this one, do you need any help ?