feat: refactor Jekyll workflow to run build job before tests and simplify manual deployment conditions

Author: SabotageAndi

.github/workflows/jekyll.yml

@@ -33,10 +33,38 @@ concurrency:
   cancel-in-progress: false
 
 jobs:
+  # Build job - uses devcontainer
+  build:
+    runs-on: ubuntu-latest
+    # Only build on push to master (not on PRs)
+    if: github.event_name == 'push' || (github.event_name == 'workflow_dispatch' && !inputs.update_snapshots)
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup Pages
+        id: pages
+        uses: actions/configure-pages@v5
+
+      - name: Build with Jekyll in devcontainer
+        uses: devcontainers/ci@v0.3
+        with:
+          push: never
+          runCmd: |
+            bundle install
+            bundle exec jekyll build --baseurl "${{ steps.pages.outputs.base_path }}"
+        env:
+          JEKYLL_ENV: production
+
+      - name: Upload artifact
+        uses: actions/upload-pages-artifact@v3
+
   # Test job - runs Playwright tests using devcontainer for consistent environment
   test:
     timeout-minutes: 60
     runs-on: ubuntu-latest
+    needs: build
+    if: always() && !cancelled()
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -107,33 +135,6 @@ jobs:
             tests/**/*.txt
           retention-days: 30
 
-  # Build job - uses devcontainer, only runs after tests pass
-  build:
-    runs-on: ubuntu-latest
-    needs: test
-    # Only build on push to master (not on PRs)
-    if: always() && !cancelled() && (github.event_name == 'push' || (github.event_name == 'workflow_dispatch' && !inputs.update_snapshots))
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-
-      - name: Setup Pages
-        id: pages
-        uses: actions/configure-pages@v5
-
-      - name: Build with Jekyll in devcontainer
-        uses: devcontainers/ci@v0.3
-        with:
-          push: never
-          runCmd: |
-            bundle install
-            bundle exec jekyll build --baseurl "${{ steps.pages.outputs.base_path }}"
-        env:
-          JEKYLL_ENV: production
-
-      - name: Upload artifact
-        uses: actions/upload-pages-artifact@v3
-
   # Deployment job - only runs after build succeeds
   deploy:
     if: needs.test.result == 'success' && needs.build.result == 'success'
@@ -149,7 +150,7 @@ jobs:
 
   # Deployment job when tests failed - requires manual approval
   deploy_manual:
-    if: needs.test.result == 'failure' && needs.build.result == 'success'
+    if: needs.test.result == 'failure'
     environment:
       name: github-pages-approval
       url: ${{ steps.deployment.outputs.page_url }}