Project maintainership

[GideonBear]

Hi @doy,

We noticed you've been inactive for a while. #318 is currently affecting a lot of people (seemingly caused by a change in bitwarden and vaultwarden).
Are you able to keep maintaining rbw?
Looking at the commit history it looks like you were coming back to rbw once in a while (~1-2 months?). This is absolutely fine, but it's been 5 months now, and #318 has been open for 2.5 months. It would be nice if these breakages with upstream could be resolved in a somewhat reasonable timeframe.
If it helps, I'm (@GideonBear) willing to do basic maintenance work (updating deps, triaging issues, reviewing/merging PRs, making releases); but I don't have the expertise to fix bugs like these (this is a way more complex project than what I've been maintaining 😄).

Thanks!
--- @GideonBear and @uwuclxdy

Ref #330

[deade1e]

Hello, I've been working on a refactor during the last days, as I found some duplicated code and overall the project doesn't seem very active as you're pointing out.

Here is my branch: https://github.com/deade1e/rbw/tree/refactor

The branch starts off of my pull request regarding the confirmation of SSH key usage but goes way deeper into deduplicating some code, decoupling logic from various functions and improving overall readability.

As of now I consider this very much work in progress, but since I like this project very much and all the *warden stuff, I think I will be able to deliver something where we could all work together in few weeks.

[GideonBear]

Oh wow, cool! That's very good to know, thank you!
I'd, of course, prefer not to fork doy/rbw, but in both cases I'm glad there's someone else passionate about it!

Please keep us updated :)

[deade1e]

Hello,

as of today I reached a point where I added a feature (confirm ssh keys use) while removing circa 1300 lines of code, and still maintaining the same functionality (with nearly 100% identical program output). The code has been heavily re-organized to avoid re-defining the same structures. There is still some duplicated behavior around and the type system is not being used as much as it should.

refactor branch:

   881 ./src/bin/rbw-agent/actions.rs
    85 ./src/bin/rbw-agent/daemon.rs
    57 ./src/bin/rbw-agent/debugger.rs
    99 ./src/bin/rbw-agent/main.rs
   158 ./src/bin/rbw-agent/notifications.rs
    51 ./src/bin/rbw-agent/sock.rs
   141 ./src/bin/rbw-agent/ssh_agent.rs
    64 ./src/bin/rbw-agent/timeout.rs
   139 ./src/bin/rbw-agent/state.rs
   174 ./src/bin/rbw-agent/agent.rs
   513 ./src/bin/rbw/main.rs
    37 ./src/bin/rbw/sock.rs
   190 ./src/bin/rbw/actions.rs
  2532 ./src/bin/rbw/commands.rs
    17 ./src/lib.rs
     1 ./src/prelude.rs
  7778 ./src/wordlist.rs
   248 ./src/error.rs
    13 ./src/base64.rs
   288 ./src/cipherstring.rs
   249 ./src/config.rs
   106 ./src/dirs.rs
    90 ./src/edit.rs
    93 ./src/identity.rs
    36 ./src/json.rs
   162 ./src/locked.rs
   287 ./src/pinentry.rs
   102 ./src/pwgen.rs
  1537 ./src/api.rs
   307 ./src/actions.rs
   191 ./src/protocol.rs
  1096 ./src/db.rs
 17722 total

main branch:

   952 ./src/bin/rbw-agent/actions.rs
   194 ./src/bin/rbw-agent/agent.rs
    86 ./src/bin/rbw-agent/daemon.rs
    55 ./src/bin/rbw-agent/debugger.rs
   109 ./src/bin/rbw-agent/main.rs
   174 ./src/bin/rbw-agent/notifications.rs
    56 ./src/bin/rbw-agent/sock.rs
   130 ./src/bin/rbw-agent/ssh_agent.rs
   146 ./src/bin/rbw-agent/state.rs
    66 ./src/bin/rbw-agent/timeout.rs
   203 ./src/bin/rbw/actions.rs
  4178 ./src/bin/rbw/commands.rs
   525 ./src/bin/rbw/main.rs
    41 ./src/bin/rbw/sock.rs
    17 ./src/lib.rs
     1 ./src/prelude.rs
  7778 ./src/wordlist.rs
   248 ./src/error.rs
   370 ./src/actions.rs
  1768 ./src/api.rs
    15 ./src/base64.rs
   315 ./src/cipherstring.rs
   249 ./src/config.rs
   316 ./src/db.rs
   114 ./src/dirs.rs
    96 ./src/edit.rs
    94 ./src/identity.rs
    44 ./src/json.rs
   165 ./src/locked.rs
   251 ./src/pinentry.rs
   201 ./src/protocol.rs
   106 ./src/pwgen.rs
 19063 total

If we don't count wordlist.rs, there is around 12% less code and the program is still the same + a small feature.

[uwuclxdy]

wow @deade1e awesome! i guess then it's about time to switch to your fork :D