diff --git a/aphrodite/engine/args_tools.py b/aphrodite/engine/args_tools.py index 84bdb38f24..80a488c3aa 100644 --- a/aphrodite/engine/args_tools.py +++ b/aphrodite/engine/args_tools.py @@ -619,9 +619,8 @@ def add_cli_args(parser: FlexibleArgumentParser) -> FlexibleArgumentParser: parser.add_argument( '--use-v2-block-manager', default=EngineArgs.use_v2_block_manager, - action='store_true', - help='Use BlockSpaceMangerV2. By default this is set to True. ' - 'Set to False to use BlockSpaceManagerV1') + type=lambda x: (str(x).lower() in ['true', '1', 'yes']), + help='Use BlockSpaceManagerV2 (default: True). Set explicitly to False to use BlockSpaceManagerV1') parser.add_argument( "--scheduler-delay-factor", "-sdf", diff --git a/aphrodite/engine/metrics.py b/aphrodite/engine/metrics.py index c4b66dadc4..fafc06127b 100644 --- a/aphrodite/engine/metrics.py +++ b/aphrodite/engine/metrics.py @@ -468,6 +468,9 @@ def _log_gauge(self, gauge, data: Union[int, float]) -> None: def _log_counter(self, counter, data: Union[int, float]) -> None: # Convenience function for logging to counter. + if data < 0: + logger.warning(f"Attempted to increment counter with negative value: {data}") + return counter.labels(**self.labels).inc(data) def _log_counter_labels(self, counter, data: CollectionsCounter,