feat: enhance domain compromise inference from ares reports#205
Merged
Conversation
…promise **Added:** - Infer domain and DC host ownership directly from has_domain_admin signals in ares domain_compromise entries, even without krbtgt evidence - Include admin_users field in aresDomainCompromise struct and synthesize evidence in findings for improved attribution - New function domainsFromDomainAdminFindings to extract owned domains from domain_admin signals in findings - New function inferDCHostsFromDomainAdmin to infer DC host ownership via domain_admin signals - New function domainAdminEvidence to format admin user evidence for findings - Tests to verify domain and host inference from has_domain_admin with and without golden_ticket **Changed:** - Update JSON query and aresDomainCompromise struct to include admin_users - Synthesize new findings for domain_admin state in writeDomainCompromiseEntries, producing explicit domain_admin:<domain> targets - Update domain and host inference logic in verify.go to account for new domain_admin findings, including markHostInferred and markDomainInferred to use new evidence and reason fields - Adjust test coverage to validate new domain ownership inference paths and ensure uncompromised domains do not produce false positives **Removed:** - Legacy comments and test references to krbtgt-only inference paths, clarifying that domain_admin state is now authoritative for domain ownership signals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes:
signals from Ares reports, not just krbtgt extraction
domain compromise
admin signals, increasing accuracy of scoreboard results
Added:
admin_usersfrom Ares domain_compromise[]metadata, including new field in struct and jq filter
domainAdminEvidencefunction to synthesize evidence details from admin useraccounts
via domain admin without golden ticket or krbtgt extraction
Changed:
ensuring correct credit even when DA accounts are built-in or not present in
credential objectives
compromised domain
signal, and golden ticket paths, improving reason and evidence reporting
unmatched findings to reduce noise in status reports
handling of Ares metadata
Removed:
signal for domain compromise