Skip to content

Commit 5565a45

Browse files
Fix review feedback
1 parent 62cad6a commit 5565a45

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

runner/internal/executor/executor.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -473,12 +473,12 @@ func (ex *RunExecutor) execJob(ctx context.Context, jobLogFile io.Writer) error
473473
defer func() { _ = cmd.Wait() }() // release resources if copy fails
474474

475475
stripper := ansistrip.NewWriter(ex.jobLogs, AnsiStripFlushInterval, AnsiStripMaxDelay, MaxBufferSize)
476+
defer stripper.Close()
476477
logger := io.MultiWriter(jobLogFile, ex.jobWsLogs, stripper)
477478
_, err = io.Copy(logger, ptm)
478479
if err != nil && !isPtyError(err) {
479480
return gerrors.Wrap(err)
480481
}
481-
stripper.Close()
482482
return gerrors.Wrap(cmd.Wait())
483483
}
484484

0 commit comments

Comments
 (0)