Skip to content

Commit 6d87b97

Browse files
Remove redundant code changes
1 parent 914fa38 commit 6d87b97

File tree

2 files changed

+0
-7
lines changed

2 files changed

+0
-7
lines changed

src/dstack/_internal/server/background/tasks/process_idle_volumes.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ async def process_idle_volumes():
4545
for volume_id in volume_ids:
4646
lockset.add(volume_id)
4747

48-
# Load volumes with related attributes in one query
4948
res = await session.execute(
5049
select(VolumeModel)
5150
.where(VolumeModel.id.in_(volume_ids))
@@ -110,12 +109,9 @@ async def _delete_idle_volumes(session: AsyncSession, volumes: List[VolumeModel]
110109
"""Delete idle volumes from cloud providers and mark as deleted in database."""
111110
for volume_model in volumes:
112111
try:
113-
# Try to delete from cloud provider first
114112
await _delete_volume_from_cloud(session, volume_model)
115113
except Exception:
116114
logger.exception("Error when deleting volume %s from cloud", volume_model.name)
117-
118-
# Always mark as deleted in database, even if cloud deletion failed
119115
try:
120116
await session.execute(
121117
update(VolumeModel)
@@ -137,11 +133,9 @@ async def _delete_volume_from_cloud(session: AsyncSession, volume_model: VolumeM
137133
volume = volume_model_to_volume(volume_model)
138134

139135
if volume.external:
140-
# External volumes are not managed by dstack
141136
return
142137

143138
if volume.provisioning_data is None:
144-
# The volume wasn't provisioned so there is nothing to delete
145139
return
146140

147141
if volume.provisioning_data.backend is None:

src/dstack/_internal/server/services/jobs/__init__.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,6 @@ async def process_terminating_job(
290290
job_model.instance_id = None
291291
instance_model.last_job_processed_at = common.get_current_datetime()
292292

293-
# Update volume timestamps
294293
volume_names = (
295294
jrd.volume_names
296295
if jrd and jrd.volume_names

0 commit comments

Comments
 (0)