Skip to content

Commit 6f3f9c5

Browse files
[Internal]: Replace Instance.termination_reason values with codes #3182
1 parent acd1f7e commit 6f3f9c5

4 files changed

Lines changed: 8 additions & 1 deletion

File tree

src/dstack/_internal/server/services/jobs/__init__.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -749,6 +749,8 @@ def _get_job_status_message(job_model: JobModel) -> str:
749749
return "stopped"
750750
elif job_model.termination_reason == JobTerminationReason.ABORTED_BY_USER:
751751
return "aborted"
752+
elif job_model.termination_reason == JobTerminationReason.NO_BALANCE:
753+
return "no balance"
752754
return job_model.status.value
753755

754756

src/tests/_internal/core/models/test_runs.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ def test_get_error_returns_expected_messages():
4343
JobTerminationReason.ABORTED_BY_USER,
4444
JobTerminationReason.TERMINATED_BY_SERVER,
4545
JobTerminationReason.CONTAINER_EXITED_WITH_ERROR,
46+
JobTerminationReason.NO_BALANCE,
4647
]
4748

4849
for reason in JobTerminationReason:

src/tests/_internal/server/background/tasks/test_process_running_jobs.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -528,7 +528,7 @@ async def test_pulling_shim_failed(self, test_db, session: AsyncSession):
528528
assert SSHTunnelMock.call_count == 3
529529
await session.refresh(job)
530530
assert job.status == JobStatus.TERMINATING
531-
assert job.termination_reason == JobTerminationReason.INTERRUPTED_BY_NO_CAPACITY
531+
assert job.termination_reason == JobTerminationReason.INSTANCE_UNREACHABLE
532532
assert job.remove_at is None
533533

534534
@pytest.mark.asyncio

src/tests/_internal/server/routers/test_fleets.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -402,6 +402,7 @@ async def test_creates_fleet(self, test_db, session: AsyncSession, client: Async
402402
"unreachable": False,
403403
"health_status": "healthy",
404404
"termination_reason": None,
405+
"termination_reason_message": None,
405406
"created": "2023-01-02T03:04:00+00:00",
406407
"backend": None,
407408
"region": None,
@@ -537,6 +538,7 @@ async def test_creates_ssh_fleet(self, test_db, session: AsyncSession, client: A
537538
"unreachable": False,
538539
"health_status": "healthy",
539540
"termination_reason": None,
541+
"termination_reason_message": None,
540542
"created": "2023-01-02T03:04:00+00:00",
541543
"region": "remote",
542544
"availability_zone": None,
@@ -708,6 +710,7 @@ async def test_updates_ssh_fleet(self, test_db, session: AsyncSession, client: A
708710
"unreachable": False,
709711
"health_status": "healthy",
710712
"termination_reason": None,
713+
"termination_reason_message": None,
711714
"created": "2023-01-02T03:04:00+00:00",
712715
"region": "remote",
713716
"availability_zone": None,
@@ -741,6 +744,7 @@ async def test_updates_ssh_fleet(self, test_db, session: AsyncSession, client: A
741744
"unreachable": False,
742745
"health_status": "healthy",
743746
"termination_reason": None,
747+
"termination_reason_message": None,
744748
"created": "2023-01-02T03:04:00+00:00",
745749
"region": "remote",
746750
"availability_zone": None,

0 commit comments

Comments
 (0)