Skip to content

Commit 740b2cc

Browse files
authored
Fix missing digitaloceanbase configurator methods (#3055)
Co-authored-by: Bihan Rana
1 parent 289a912 commit 740b2cc

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

src/dstack/_internal/core/backends/amddevcloud/configurator.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
from typing import Optional
22

33
from dstack._internal.core.backends.amddevcloud.backend import AMDDevCloudBackend
4+
from dstack._internal.core.backends.base.configurator import BackendRecord
45
from dstack._internal.core.backends.digitalocean_base.api_client import DigitalOceanAPIClient
56
from dstack._internal.core.backends.digitalocean_base.backend import BaseDigitalOceanBackend
67
from dstack._internal.core.backends.digitalocean_base.configurator import (
@@ -17,7 +18,7 @@ class AMDDevCloudConfigurator(BaseDigitalOceanConfigurator):
1718
BACKEND_CLASS = AMDDevCloudBackend
1819
API_URL = "https://api-amd.digitalocean.com"
1920

20-
def get_backend(self, record) -> BaseDigitalOceanBackend:
21+
def get_backend(self, record: BackendRecord) -> BaseDigitalOceanBackend:
2122
config = self._get_config(record)
2223
return AMDDevCloudBackend(config=config, api_url=self.API_URL)
2324

src/dstack/_internal/core/backends/digitalocean_base/configurator.py

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
)
88
from dstack._internal.core.backends.digitalocean_base.backend import BaseDigitalOceanBackend
99
from dstack._internal.core.backends.digitalocean_base.models import (
10-
AnyBaseDigitalOceanBackendConfig,
1110
AnyBaseDigitalOceanCreds,
1211
BaseDigitalOceanBackendConfig,
1312
BaseDigitalOceanBackendConfigWithCreds,
@@ -33,16 +32,20 @@ def create_backend(
3332
auth=BaseDigitalOceanCreds.parse_obj(config.creds).json(),
3433
)
3534

36-
def get_backend_config(
37-
self, record: BackendRecord, include_creds: bool
38-
) -> AnyBaseDigitalOceanBackendConfig:
35+
def get_backend_config_with_creds(
36+
self, record: BackendRecord
37+
) -> BaseDigitalOceanBackendConfigWithCreds:
38+
config = self._get_config(record)
39+
return BaseDigitalOceanBackendConfigWithCreds.__response__.parse_obj(config)
40+
41+
def get_backend_config_without_creds(
42+
self, record: BackendRecord
43+
) -> BaseDigitalOceanBackendConfig:
3944
config = self._get_config(record)
40-
if include_creds:
41-
return BaseDigitalOceanBackendConfigWithCreds.__response__.parse_obj(config)
4245
return BaseDigitalOceanBackendConfig.__response__.parse_obj(config)
4346

4447
def get_backend(self, record: BackendRecord) -> BaseDigitalOceanBackend:
45-
pass
48+
raise NotImplementedError("Subclasses must implement get_backend")
4649

4750
def _get_config(self, record: BackendRecord) -> BaseDigitalOceanConfig:
4851
return BaseDigitalOceanConfig.__response__(

0 commit comments

Comments
 (0)