Skip to content

Commit c9caba5

Browse files
[UX] Minor improvement for dstack server (#3308)
1 parent f98a4cf commit c9caba5

4 files changed

Lines changed: 20 additions & 5 deletions

File tree

src/dstack/_internal/cli/commands/server.py

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,14 @@ def _register(self):
3232
help="Bind socket to this port. Defaults to 3000.",
3333
default=os.getenv("DSTACK_SERVER_PORT", 3000),
3434
)
35-
self._parser.add_argument(
35+
group = self._parser.add_mutually_exclusive_group()
36+
group.add_argument(
37+
"-d",
38+
"--debug",
39+
help="Enable debug logging level (same as [code]-l debug[/code])",
40+
action="store_true",
41+
)
42+
group.add_argument(
3643
"-l",
3744
"--log-level",
3845
type=str,
@@ -64,7 +71,7 @@ def _command(self, args: argparse.Namespace):
6471

6572
os.environ["DSTACK_SERVER_HOST"] = args.host
6673
os.environ["DSTACK_SERVER_PORT"] = str(args.port)
67-
os.environ["DSTACK_SERVER_LOG_LEVEL"] = args.log_level
74+
os.environ["DSTACK_SERVER_LOG_LEVEL"] = "DEBUG" if args.debug else args.log_level
6875
if args.yes:
6976
os.environ["DSTACK_UPDATE_DEFAULT_PROJECT"] = "1"
7077
if args.no:

src/dstack/_internal/server/app.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,12 @@ async def lifespan(app: FastAPI):
161161
logger.info("Background processing is disabled")
162162
PROBES_SCHEDULER.start()
163163
dstack_version = DSTACK_VERSION if DSTACK_VERSION else "(no version)"
164-
logger.info(
164+
job_network_mode_log = (
165+
logger.info
166+
if settings.JOB_NETWORK_MODE != settings.DEFAULT_JOB_NETWORK_MODE
167+
else logger.debug
168+
)
169+
job_network_mode_log(
165170
"Job network mode: %s (%d)",
166171
settings.JOB_NETWORK_MODE.name,
167172
settings.JOB_NETWORK_MODE.value,

src/dstack/_internal/server/services/plugins.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ def load_plugins(enabled_plugins: list[str]):
7474

7575
for name, import_path in _BUILTIN_PLUGINS.items():
7676
if name not in enabled_plugins:
77-
logger.info(
77+
logger.debug(
7878
("Found not enabled builtin plugin %s. Plugin will not be loaded."),
7979
name,
8080
)

src/dstack/_internal/server/settings.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,9 +153,12 @@ class JobNetworkMode(Enum):
153153
FORCED_BRIDGE = 3
154154

155155

156+
DEFAULT_JOB_NETWORK_MODE = JobNetworkMode.HOST_WHEN_POSSIBLE
157+
158+
156159
def _get_job_network_mode() -> JobNetworkMode:
157160
# Current default
158-
mode = JobNetworkMode.HOST_WHEN_POSSIBLE
161+
mode = DEFAULT_JOB_NETWORK_MODE
159162
bridge_var = "DSTACK_FORCE_BRIDGE_NETWORK"
160163
force_bridge = environ.get_bool(bridge_var)
161164
mode_var = "DSTACK_SERVER_JOB_NETWORK_MODE"

0 commit comments

Comments
 (0)