Tweak Compute API for dstack Sky

Author: jvstme

src/dstack/_internal/core/backends/base/compute.py

@@ -23,6 +23,7 @@
     DSTACK_RUNNER_SSH_PORT,
     DSTACK_SHIM_HTTP_PORT,
 )
+from dstack._internal.core.models.backends.base import BackendType
 from dstack._internal.core.models.configurations import LEGACY_REPO_DIR
 from dstack._internal.core.models.gateways import (
     GatewayComputeConfiguration,
@@ -403,9 +404,13 @@ def is_suitable_placement_group(
         """
         pass
 
-    def are_placement_groups_compatible_with_reservations(self) -> bool:
+    def are_placement_groups_compatible_with_reservations(self, backend_type: BackendType) -> bool:
         """
         Whether placement groups can be used for instances provisioned in reservations.
+
+        Arguments:
+            backend_type: matches the backend type of this compute, unless this compute is a proxy
+                for other backends (dstack Sky)
         """
         return True
 

src/dstack/_internal/core/backends/gcp/compute.py

@@ -528,7 +528,7 @@ def is_suitable_placement_group(
     ) -> bool:
         return placement_group.configuration.region == instance_offer.region
 
-    def are_placement_groups_compatible_with_reservations(self) -> bool:
+    def are_placement_groups_compatible_with_reservations(self, backend_type: BackendType) -> bool:
         # Cannot use our own placement policies when provisioning in a reservation.
         # Instead, we use the placement policy defined in reservation settings.
         return False

src/dstack/_internal/server/background/tasks/process_instances.py

@@ -560,7 +560,7 @@ async def _create_instance(session: AsyncSession, instance: InstanceModel) -> No
             and instance_offer.backend in BACKENDS_WITH_PLACEMENT_GROUPS_SUPPORT
             and isinstance(compute, ComputeWithPlacementGroupSupport)
             and (
-                compute.are_placement_groups_compatible_with_reservations()
+                compute.are_placement_groups_compatible_with_reservations(instance_offer.backend)
                 or instance_configuration.reservation is None
             )
             and instance.fleet