fix: use context.TODO() for umount to prevent filesystem corruption

matiasinsaurralde · matiasinsaurralde · commit ee4f870059c5 · 2025-10-27T12:50:19.000-03:00
Prevents umount command cancellation which could lead to data corruption
and filesystem inconsistencies. Addresses review feedback about cancelling
critical filesystem operations.

Signed-off-by: Matías Insaurralde &lt;matias@insaurral.de&gt;
diff --git a/runner/internal/shim/docker.go b/runner/internal/shim/docker.go
@@ -540,7 +540,7 @@ func unmountVolumes(ctx context.Context, taskConfig TaskConfig) error {
 			log.Info(ctx, "skipping", "mountpoint", mountPoint, "output", output)
 			continue
 		}
-		cmd = exec.CommandContext(ctx, "umount", "-qf", mountPoint)
+		cmd = exec.CommandContext(context.TODO(), "umount", "-qf", mountPoint)
 		if output, err := cmd.CombinedOutput(); err != nil {
 			log.Error(ctx, "failed to unmount", "mountpoint", mountPoint, "output", output)
 			failed = append(failed, mountPoint)

Original file line number	Diff line number	Diff line change
`@@ -540,7 +540,7 @@ func unmountVolumes(ctx context.Context, taskConfig TaskConfig) error {`
`540`	`540`	`log.Info(ctx, "skipping", "mountpoint", mountPoint, "output", output)`
`541`	`541`	`continue`
`542`	`542`	`}`
`543`		`- cmd = exec.CommandContext(ctx, "umount", "-qf", mountPoint)`
	`543`	`+ cmd = exec.CommandContext(context.TODO(), "umount", "-qf", mountPoint)`
`544`	`544`	`if output, err := cmd.CombinedOutput(); err != nil {`
`545`	`545`	`log.Error(ctx, "failed to unmount", "mountpoint", mountPoint, "output", output)`
`546`	`546`	`failed = append(failed, mountPoint)`