-
Notifications
You must be signed in to change notification settings - Fork 222
[Bug]: Use a unique token for log pagination instead of a timestamp #2833
Copy link
Copy link
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Steps to reproduce
- Adjust the source code to display log
log.timestampinstead oflog.message - Add
print("next_start_time", next_start_time)at the end of thewhile loop(resp = self._api_client.logs.pollinruns.py)
Run the following with the file/AWS/GCP logging.
type: task
name: print-numbers
commands:
- |
python -c "for i in range(1, 100001): print(i)"$ dstack logs print-numbers | sort | uniq -c > print-numbers.txtActual behaviour
The polling function across all storages (file/GCP/AWS) uses start_time as a way to paginate logs.
In case too many event share the same timestamp, it truncates the output.
Expected behaviour start_time for pagination.
It should always use a unique token:
- AWS/GCP - support their own
- File logging may use line number from the file.
The polling function should NOT use
dstack version
0.19.15
Server logs
Additional information
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working