From 35e6d0e264e85171fab91b0035f5bce11949e57c Mon Sep 17 00:00:00 2001 From: Carlo Piovesan Date: Thu, 3 Apr 2025 17:10:16 +0200 Subject: [PATCH 1/4] Bump cmake_minimum_required --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index c95486c..b7e9ac2 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1,4 +1,4 @@ -cmake_minimum_required(VERSION 2.8.12) +cmake_minimum_required(VERSION 3.5...3.29) # Set extension name here set(TARGET_NAME arrow) From d33aa136cd268352502ef9dd522185de4c5f43aa Mon Sep 17 00:00:00 2001 From: Carlo Piovesan Date: Thu, 3 Apr 2025 17:19:21 +0200 Subject: [PATCH 2/4] Pass CMAKE_POLICY_VERSION_MINIMUM down to arrow --- CMakeLists.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index b7e9ac2..d9a5d56 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -45,6 +45,7 @@ ExternalProject_Add( -DARROW_WITH_LZ4=OFF -DARROW_WITH_SNAPPY=OFF -DARROW_WITH_ZLIB=OFF -DARROW_WITH_ZSTD=OFF -DARROW_WITH_UCX=OFF -DARROW_WITH_UTF8PROC=OFF -DARROW_WITH_RE2=OFF /cpp + -DCMAKE_POLICY_VERSION_MINIMUM=3.5 CMAKE_ARGS -Wno-dev UPDATE_COMMAND "") From 2c899accbb8f286aa91ba3438deec121aeec8f78 Mon Sep 17 00:00:00 2001 From: Carlo Piovesan Date: Thu, 3 Apr 2025 17:25:49 +0200 Subject: [PATCH 3/4] Set x --- CMakeLists.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index d9a5d56..45cf037 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -16,6 +16,8 @@ else() set(OSX_ARCH_FLAG "") endif() +set(CMAKE_POLICY_VERSION_MINIMUM 3.5) + # Building Arrow include(ExternalProject) ExternalProject_Add( From f09de6fe6edc3903d4f3713a8c46277c6c37c67f Mon Sep 17 00:00:00 2001 From: Carlo Piovesan Date: Thu, 3 Apr 2025 17:38:58 +0200 Subject: [PATCH 4/4] Set also via ENV --- CMakeLists.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index 45cf037..cde366b 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -16,7 +16,9 @@ else() set(OSX_ARCH_FLAG "") endif() +# Do they actually work? set(CMAKE_POLICY_VERSION_MINIMUM 3.5) +set(ENV{CMAKE_POLICY_VERSION_MINIMUM} 3.5) # Building Arrow include(ExternalProject)