Update test

Author: dwjohnston

src/library/config/defaultFunctions.test.ts

@@ -1,107 +1,28 @@
 import { describe, it, expect } from 'vitest';
-
-/**
- * This is a copy of the helper function from defaultFunctions.ts for testing purposes.
- */
-function decodeBase64WithUTF8(base64: string): string {
-    const cleanedBase64 = base64.replace(/\s/g, '');
-    const binaryString = atob(cleanedBase64);
-    const bytes = new Uint8Array(binaryString.length);
-    for (let i = 0; i < binaryString.length; i++) {
-        bytes[i] = binaryString.charCodeAt(i);
-    }
-    const decoder = new TextDecoder('utf-8');
-    return decoder.decode(bytes);
-}
+import { decodeBase64WithUTF8 } from './defaultFunctions';
 
 describe('Base64 UTF-8 Decoding', () => {
-    it('should correctly decode base64 with ASCII text', () => {
-        // Simple ASCII text
-        const text = 'Hello World';
-        const encoder = new TextEncoder();
-        const bytes = encoder.encode(text);
-        const binaryString = String.fromCharCode(...bytes);
-        const base64 = btoa(binaryString);
-        
-        const result = decodeBase64WithUTF8(base64);
-        expect(result).toBe(text);
-    });
-
-    it('should correctly decode base64 with emoji', () => {
-        // Text with emoji - the actual issue from GitHub
-        const text = '// 👇 Check this out';
-        const encoder = new TextEncoder();
-        const bytes = encoder.encode(text);
-        const binaryString = String.fromCharCode(...bytes);
-        const base64 = btoa(binaryString);
-        
-        const result = decodeBase64WithUTF8(base64);
-        expect(result).toBe(text);
-        expect(result).toContain('👇');
-    });
+    it('should match the deprecated escape/unescape pattern behavior', () => {
+        const text = '// 👇 This is a comment with emoji';
 
-    it('should correctly decode base64 with pointing up emoji', () => {
-        // The specific emoji mentioned in the user's comment
-        const text = '☝️';
-        const encoder = new TextEncoder();
-        const bytes = encoder.encode(text);
-        const binaryString = String.fromCharCode(...bytes);
-        const base64 = btoa(binaryString);
-        
-        const result = decodeBase64WithUTF8(base64);
-        expect(result).toBe(text);
-    });
+        // We're using the deprecated pattern for a sanity check to see that the AI generated version is correct.
+        const deprecatedEncodedString = btoa(unescape(encodeURIComponent(text)));
 
-    it('should correctly decode base64 with multiple emojis', () => {
-        const text = '👍 👎 😕 ❤️ 🎉';
-        const encoder = new TextEncoder();
-        const bytes = encoder.encode(text);
-        const binaryString = String.fromCharCode(...bytes);
-        const base64 = btoa(binaryString);
-        
-        const result = decodeBase64WithUTF8(base64);
-        expect(result).toBe(text);
-    });
-
-    it('should correctly decode base64 with mixed content', () => {
-        const text = 'export function Example() {\n    // 👇 This is a comment\n    return <div>Hello</div>;\n}';
+        // Verify our solution gives the same result as the deprecated method
         const encoder = new TextEncoder();
         const bytes = encoder.encode(text);
         const binaryString = String.fromCharCode(...bytes);
         const base64 = btoa(binaryString);
-        
-        const result = decodeBase64WithUTF8(base64);
-        expect(result).toBe(text);
-        expect(result).toContain('👇');
-    });
 
-    it('should handle base64 with whitespace (as GitHub API might return)', () => {
-        const text = 'Test 👍';
-        const encoder = new TextEncoder();
-        const bytes = encoder.encode(text);
-        const binaryString = String.fromCharCode(...bytes);
-        const base64 = btoa(binaryString);
-        const base64WithWhitespace = base64.slice(0, 5) + '\n' + base64.slice(5);
-        
-        const result = decodeBase64WithUTF8(base64WithWhitespace);
-        expect(result).toBe(text);
-    });
 
-    it('should match the deprecated escape/unescape pattern behavior', () => {
-        // Verify our solution gives the same result as the deprecated method
-        const text = '// 👇 This is a comment with emoji';
-        const encoder = new TextEncoder();
-        const bytes = encoder.encode(text);
-        const binaryString = String.fromCharCode(...bytes);
-        const base64 = btoa(binaryString);
-        
+        expect(deprecatedEncodedString).toBe(base64);
         const modernResult = decodeBase64WithUTF8(base64);
-        
+
         // The deprecated pattern: decodeURIComponent(escape(atob(base64)))
         // escape() converts the incorrectly-decoded UTF-8 bytes to percent-encoding
         // decodeURIComponent() then interprets those percent-encoded bytes as UTF-8
         const deprecatedResult = decodeURIComponent(escape(atob(base64)));
-        
+
         expect(modernResult).toBe(deprecatedResult);
         expect(modernResult).toBe(text);
     });

src/library/config/defaultFunctions.ts

@@ -6,6 +6,8 @@ import { ErrorResponses } from "./GithubPermalinkContext";
 /**
  * This is AI generated code from GitHub Copilot.
  * See: https://github.com/dwjohnston/react-github-permalink/pull/79
+ * But based on my reading of this:https://stackoverflow.com/a/56647993/1068446
+ * But the suggested answer is using deprecated functions (escape/unescape)
  * 
  * Properly decode base64 string with UTF-8 support.
  * GitHub API returns base64-encoded content that may contain UTF-8 characters like emojis.
@@ -16,7 +18,7 @@ import { ErrorResponses } from "./GithubPermalinkContext";
  * The solution: Convert the binary string to a byte array, then use TextDecoder to properly
  * interpret those bytes as UTF-8.
  */
-function decodeBase64WithUTF8(base64: string): string {
+export function decodeBase64WithUTF8(base64: string): string {
     // Remove whitespace that GitHub API might include
     const cleanedBase64 = base64.replace(/\s/g, '');