-Remove unnecesary tests and unnecesary async assertions.

-Improve coverage

Author: PelayoFelgueroso

apps/website/test/theme-generator/BrandingDetails.test.tsx

@@ -22,21 +22,25 @@ jest.mock("react-color", () => ({
 }));
 
 describe("BrandingDetails", () => {
+  beforeAll(() => {
+    global.URL.createObjectURL = jest.fn(() => "blob:mock-url");
+  });
+
+  const colors: Colors = {
+    primary: "#5F249F" as CssColor,
+    secondary: "#0067B3" as CssColor,
+    tertiary: "#F7CF2B" as CssColor,
+    neutral: "#999999" as CssColor,
+    info: "#0067B3" as CssColor,
+    success: "#59D97D" as CssColor,
+    error: "#FE344F" as CssColor,
+    warning: "#F59F3D" as CssColor,
+  };
+
   it("renders color sections with ColorCard components", () => {
     const onColorsChange = jest.fn();
     const onLogosChange = jest.fn();
 
-    const colors: Colors = {
-      primary: "#5F249F" as CssColor,
-      secondary: "#0067B3" as CssColor,
-      tertiary: "#F7CF2B" as CssColor,
-      neutral: "#999999" as CssColor,
-      info: "#0067B3" as CssColor,
-      success: "#59D97D" as CssColor,
-      error: "#FE344F" as CssColor,
-      warning: "#F59F3D" as CssColor,
-    };
-
     const logos: Logos = { mainLogo: [], footerLogo: [], footerReducedLogo: [], favicon: [] };
 
     render(
@@ -47,21 +51,10 @@ describe("BrandingDetails", () => {
     expect(screen.getByText("Primary")).toBeInTheDocument();
   });
 
-  it("updates colors when input value changes", async () => {
+  it("updates colors when input value changes", () => {
     const onColorsChange = jest.fn();
     const onLogosChange = jest.fn();
 
-    const colors: Colors = {
-      primary: "#5F249F" as CssColor,
-      secondary: "#0067B3" as CssColor,
-      tertiary: "#F7CF2B" as CssColor,
-      neutral: "#999999" as CssColor,
-      info: "#0067B3" as CssColor,
-      success: "#59D97D" as CssColor,
-      error: "#FE344F" as CssColor,
-      warning: "#F59F3D" as CssColor,
-    };
-
     const logos: Logos = { mainLogo: [], footerLogo: [], footerReducedLogo: [], favicon: [] };
 
     render(
@@ -72,31 +65,17 @@ describe("BrandingDetails", () => {
     fireEvent.change(primaryInput, { target: { value: "#111111" } });
     fireEvent.blur(primaryInput);
 
-    await waitFor(() => {
-      expect(onColorsChange).toHaveBeenCalledWith(
-        expect.objectContaining({
-          primary: "#111111",
-          secondary: "#0067B3",
-        })
-      );
-    });
+    expect(onColorsChange).toHaveBeenCalledWith(
+      expect.objectContaining({
+        primary: "#111111",
+      })
+    );
   });
 
   it("renders logo sections with FileInput components", () => {
     const onColorsChange = jest.fn();
     const onLogosChange = jest.fn();
 
-    const colors: Colors = {
-      primary: "#5F249F" as CssColor,
-      secondary: "#0067B3" as CssColor,
-      tertiary: "#F7CF2B" as CssColor,
-      neutral: "#999999" as CssColor,
-      info: "#0067B3" as CssColor,
-      success: "#59D97D" as CssColor,
-      error: "#FE344F" as CssColor,
-      warning: "#F59F3D" as CssColor,
-    };
-
     const logos: Logos = {
       mainLogo: [],
       footerLogo: [{ file: new File(["f"], "footer.png", { type: "image/png" }) }],
@@ -111,4 +90,28 @@ describe("BrandingDetails", () => {
     expect(screen.getByText("Main logo")).toBeInTheDocument();
     expect(screen.getByText("Default footer logo")).toBeInTheDocument();
   });
+
+  it("updates logos when a file is selected", async () => {
+    const onColorsChange = jest.fn();
+    const onLogosChange = jest.fn();
+
+    const logos: Logos = { mainLogo: [], footerLogo: [], footerReducedLogo: [], favicon: [] };
+
+    render(
+      <BrandingDetails colors={colors} onColorsChange={onColorsChange} logos={logos} onLogosChange={onLogosChange} />
+    );
+
+    const file = new File(["logo content"], "main-logo.png", { type: "image/png" });
+    const mainLogoInput = screen.getByLabelText("Main logo");
+    fireEvent.change(mainLogoInput, { target: { files: [file] } });
+
+    await waitFor(() => {
+      expect(onLogosChange).toHaveBeenCalled();
+      const firstCallArguments = onLogosChange.mock.calls[0] as [Logos];
+      const updatedLogos = firstCallArguments[0];
+      expect(updatedLogos.mainLogo).toHaveLength(1);
+      expect(updatedLogos.mainLogo[0]?.file).toBeInstanceOf(File);
+      expect(updatedLogos.mainLogo[0]?.file.name).toBe("main-logo.png");
+    });
+  });
 });