Skip to content

Commit e34b19c

Browse files
authored
Add vendored-openssl feature (#16)
* Add vendored-openssl feature * Fix megalinter whining * Update codeowners * Revert "Update codeowners" This reverts commit 9e9a9e7. * Update codeowners again
1 parent 3c4449d commit e34b19c

5 files changed

Lines changed: 18 additions & 7 deletions

File tree

.github/CODEOWNERS

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
# Default owners for all files
2-
* @petekubiak @ScottGibb @jamessizeland
2+
* @petekubiak @ScottGibb @jamessizeland @mrossington
33

44
# Override the default owners and remove ownership for specific files
55
Cargo.toml
66

77
# Override the default owners and remove ownership for the .github/workflows directory
8-
.github/workflows/
8+
.github/workflows/

CODE_OF_CONDUCT.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,11 +115,11 @@ the community.
115115
## Attribution
116116

117117
This Code of Conduct is adapted from the [Contributor Covenant][homepage],
118-
version 2.0, available [here](https://www.contributor-covenant.org/version/2/0/code_of_conduct.html).
118+
[version 2.0](https://www.contributor-covenant.org/version/2/0/code_of_conduct.html).
119119

120120
Community Impact Guidelines were inspired by [Mozilla's code of conduct
121121
enforcement ladder](https://github.com/mozilla/diversity).
122122

123123
[homepage]: https://www.contributor-covenant.org
124124

125-
For answers to common questions about this code of conduct, see the [FAQ](https://www.contributor-covenant.org/faq). Translations are available [here](https://www.contributor-covenant.org/translations).
125+
For answers to common questions about this code of conduct, see the [FAQ](https://www.contributor-covenant.org/faq). [Translations are available here](https://www.contributor-covenant.org/translations).

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ Thank you for considering contributing to the Commitment issues project! We welc
3838

3939
## Code Style
4040

41-
- Follow the existing code style. This can be done by running `mega-linter-runner --fix` before your commit. This check will also run in the CI when doing a merge and point out any fixes that are required. More information on MegaLinter can be found [here](https://megalinter.io/latest/)
41+
- Follow the existing code style. This can be done by running `mega-linter-runner --fix` before your commit. This check will also run in the CI when doing a merge and point out any fixes that are required. [More information on MegaLinter can be found here](https://megalinter.io/latest/)
4242
- Write clear and concise commit messages.
4343
- Include comments where necessary.
4444

Cargo.toml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "commitment-issues"
3-
version = "0.1.0"
3+
version = "0.1.1"
44
edition = "2021"
55
authors = ["Pete Kubiak <peter.kubiak@dyson.com>"]
66

@@ -14,3 +14,7 @@ syn = "2.0"
1414

1515
[lib]
1616
proc-macro = true
17+
18+
[features]
19+
default = []
20+
vendored-openssl = ["git2/vendored-openssl"]

README.md

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ Embed git repository metadata into compiled binaries.
1616
### Creating a new project from template
1717

1818
A very simple `cargo generate` example template is provided which demonstrates usage of the crate in a natively-compiled binary.
19-
To use the template, you will need cargo generate installed (for instructions see [here](https://github.com/cargo-generate/cargo-generate/tree/main)).
19+
To use the template, you will need cargo generate installed (for instructions see [the cargo-generate docs](https://github.com/cargo-generate/cargo-generate/tree/main)).
2020

2121
#### Generate the project
2222

@@ -91,6 +91,13 @@ The template's [main.rs](https://github.com/dysonltd/commitment-issues/blob/main
9191

9292
Compile and run your project using your standard process.
9393

94+
## Troubleshooting
95+
96+
This crate relies on git2, which in turn relies on openssl-sys.
97+
By default, openssl-sys has libssl-dev as a dependency.
98+
This can sometimes cause issues when building in dev containers or cross-compiling.
99+
If you see issues relating to being unable to find openssl headers, try activating the `openssl-vendored` feature.
100+
94101
## Inspecting binary metadata
95102

96103
The metadata can be found in a section called ".metadata" within the executable binary generated by cargo.

0 commit comments

Comments
 (0)