Small thing here - My linter is complaining about the code here and here, because we should really be using == for string comparison, not is, right?
if bintype == "log": vs if bintype is "log"
I looked through the issues and didn't see anyone else bringing this up. I'm happy to submit a PR but I wanted to bring it up here, before I just went ahead and did that.
Please let me know if a quick PR for this would be welcomed!
Small thing here - My linter is complaining about the code here and here, because we should really be using
==for string comparison, notis, right?if bintype == "log":vsif bintype is "log"I looked through the issues and didn't see anyone else bringing this up. I'm happy to submit a PR but I wanted to bring it up here, before I just went ahead and did that.
Please let me know if a quick PR for this would be welcomed!