From 87b8d4b98b130caa2fc05e7447e664bade7bdca9 Mon Sep 17 00:00:00 2001
From: Adam Preuss <a_preuss@apple.com>
Date: Wed, 7 May 2025 13:50:14 -0600
Subject: [PATCH] Do not recreate the bouncycastle provider every time.

---
 .../java/org/eclipse/biscuit/crypto/SECP256R1KeyPair.java  | 3 ++-
 .../java/org/eclipse/biscuit/crypto/SignatureTest.java     | 7 -------
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/src/main/java/org/eclipse/biscuit/crypto/SECP256R1KeyPair.java b/src/main/java/org/eclipse/biscuit/crypto/SECP256R1KeyPair.java
index d8d7f4d4..842a2872 100644
--- a/src/main/java/org/eclipse/biscuit/crypto/SECP256R1KeyPair.java
+++ b/src/main/java/org/eclipse/biscuit/crypto/SECP256R1KeyPair.java
@@ -69,7 +69,8 @@ final class SECP256R1KeyPair extends KeyPair {
   }
 
   static Signature getSignature() throws NoSuchAlgorithmException {
-    return Signature.getInstance("SHA256withECDSA", new BouncyCastleProvider());
+    return Signature.getInstance(
+        "SHA256withECDSA", Security.getProvider(BouncyCastleProvider.PROVIDER_NAME));
   }
 
   @Override
diff --git a/src/test/java/org/eclipse/biscuit/crypto/SignatureTest.java b/src/test/java/org/eclipse/biscuit/crypto/SignatureTest.java
index 46100a65..dd094f2c 100644
--- a/src/test/java/org/eclipse/biscuit/crypto/SignatureTest.java
+++ b/src/test/java/org/eclipse/biscuit/crypto/SignatureTest.java
@@ -14,22 +14,15 @@
 import java.security.InvalidKeyException;
 import java.security.NoSuchAlgorithmException;
 import java.security.SecureRandom;
-import java.security.Security;
 import java.security.SignatureException;
 import org.eclipse.biscuit.error.Error;
 import org.eclipse.biscuit.token.Biscuit;
-import org.bouncycastle.jce.provider.BouncyCastleProvider;
 import org.junit.jupiter.api.Test;
 
 /**
  * @serial exclude
  */
 public class SignatureTest {
-
-  static {
-    Security.addProvider(new BouncyCastleProvider());
-  }
-
   @Test
   public void testSerialize() {
     prTestSerialize(Schema.PublicKey.Algorithm.Ed25519, 32);