From c00179a8ac6183420472e67f889351883313fbb2 Mon Sep 17 00:00:00 2001 From: Jared Galanis Date: Tue, 10 Mar 2026 12:10:18 -0400 Subject: [PATCH 1/3] fix: updates for ember lts upgrade --- tests/page_model/SubmissionMetadata.js | 9 +++++++-- tests/proxySubmissionTests.js | 2 +- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/tests/page_model/SubmissionMetadata.js b/tests/page_model/SubmissionMetadata.js index 5392bc0..06dbc16 100644 --- a/tests/page_model/SubmissionMetadata.js +++ b/tests/page_model/SubmissionMetadata.js @@ -50,11 +50,16 @@ class SubmissionMetadata { const publicationDateInput = Selector( 'div[data-name=publicationDate] input' ); + // Native expects yyyy-mm-dd format. + // Convert mm/dd/yyyy to yyyy-mm-dd for programmatic input. + const [mm, dd, yyyy] = date.split('/'); + const isoDate = `${yyyy}-${mm}-${dd}`; await t .expect(publicationDateInput.exists) .ok() - .click(publicationDateInput) - .pressKey(date.split('').join(' ')); + .typeText(publicationDateInput, isoDate, { replace: true, paste: true }) + .dispatchEvent(publicationDateInput, 'input', { bubbles: true }) + .dispatchEvent(publicationDateInput, 'change', { bubbles: true }); } async clickNextToFiles() { diff --git a/tests/proxySubmissionTests.js b/tests/proxySubmissionTests.js index addcb0b..e0418ac 100644 --- a/tests/proxySubmissionTests.js +++ b/tests/proxySubmissionTests.js @@ -58,7 +58,7 @@ test('can walk through a proxy submission workflow and make a submission - with await t.click(searchForUsers); // Check search results - const searchResultsModal = Selector('.ember-modal-dialog'); + const searchResultsModal = Selector('.pass-modal-dialog'); await t.expect(searchResultsModal.exists).ok(); const userHasGrantsLink = Selector('a') .withAttribute('data-test-found-proxy-user') From 38551ef95db2ff488b6dc01a4745f06b656842ed Mon Sep 17 00:00:00 2001 From: Jared Galanis Date: Tue, 10 Mar 2026 13:11:35 -0400 Subject: [PATCH 2/3] fix: format string ahead of calling date input func --- tests/journalTests.js | 2 +- tests/noJournalTests.js | 2 +- tests/page_model/SubmissionMetadata.js | 9 ++------- tests/proxySubmissionTests.js | 2 +- 4 files changed, 5 insertions(+), 10 deletions(-) diff --git a/tests/journalTests.js b/tests/journalTests.js index d0e1499..5c695d5 100644 --- a/tests/journalTests.js +++ b/tests/journalTests.js @@ -65,7 +65,7 @@ test('can walk through an submission workflow and make a submission with journal await submissionMetadataPage.verifyArticleTitle(submissionTitle); await submissionMetadataPage.verifyJournalTitle('PASS_E2E_TEST_JOURNAL'); await submissionMetadataPage.inputAuthor('PASS_E2E_TEST_AUTHOR'); - await submissionMetadataPage.inputPublicationDate('05/02/2010'); + await submissionMetadataPage.inputPublicationDate('2010-05-02'); await submissionMetadataPage.clickNextToFiles(); diff --git a/tests/noJournalTests.js b/tests/noJournalTests.js index d6d851a..59fb6a2 100644 --- a/tests/noJournalTests.js +++ b/tests/noJournalTests.js @@ -61,7 +61,7 @@ test('can walk through a submission workflow and make a submission - without sel await submissionMetadataPage.verifyArticleTitle(submissionTitle); await submissionMetadataPage.verifyJournalTitle(''); await submissionMetadataPage.inputAuthor('PASS_E2E_TEST_AUTHOR'); - await submissionMetadataPage.inputPublicationDate('05/02/2010'); + await submissionMetadataPage.inputPublicationDate('2010-05-02'); await submissionMetadataPage.clickNextToFiles(); await submissionFilesPage.verifyOAManuscriptsNotExists(); diff --git a/tests/page_model/SubmissionMetadata.js b/tests/page_model/SubmissionMetadata.js index 06dbc16..54aca92 100644 --- a/tests/page_model/SubmissionMetadata.js +++ b/tests/page_model/SubmissionMetadata.js @@ -50,16 +50,11 @@ class SubmissionMetadata { const publicationDateInput = Selector( 'div[data-name=publicationDate] input' ); - // Native expects yyyy-mm-dd format. - // Convert mm/dd/yyyy to yyyy-mm-dd for programmatic input. - const [mm, dd, yyyy] = date.split('/'); - const isoDate = `${yyyy}-${mm}-${dd}`; await t .expect(publicationDateInput.exists) .ok() - .typeText(publicationDateInput, isoDate, { replace: true, paste: true }) - .dispatchEvent(publicationDateInput, 'input', { bubbles: true }) - .dispatchEvent(publicationDateInput, 'change', { bubbles: true }); + .click(publicationDateInput) + .typeText(publicationDateInput, date, { paste: true }); } async clickNextToFiles() { diff --git a/tests/proxySubmissionTests.js b/tests/proxySubmissionTests.js index e0418ac..cd32305 100644 --- a/tests/proxySubmissionTests.js +++ b/tests/proxySubmissionTests.js @@ -158,7 +158,7 @@ async function walkThroughSubmissionFlow(t, hasAccount) { await submissionMetadataPage.verifyJournalTitle( 'Publications of the Astronomical Society of the Pacific' ); - await submissionMetadataPage.inputPublicationDate('05/02/2010'); + await submissionMetadataPage.inputPublicationDate('2010-05-02'); await submissionMetadataPage.clickNextToFiles(); From ba5babb230323d359e76ad0aea98c9f6533c6d66 Mon Sep 17 00:00:00 2001 From: Jared Galanis Date: Tue, 10 Mar 2026 13:12:28 -0400 Subject: [PATCH 3/3] chore: revert modal dialog class to reduce changes --- tests/proxySubmissionTests.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/proxySubmissionTests.js b/tests/proxySubmissionTests.js index cd32305..db887ba 100644 --- a/tests/proxySubmissionTests.js +++ b/tests/proxySubmissionTests.js @@ -58,7 +58,7 @@ test('can walk through a proxy submission workflow and make a submission - with await t.click(searchForUsers); // Check search results - const searchResultsModal = Selector('.pass-modal-dialog'); + const searchResultsModal = Selector('.ember-modal-dialog'); await t.expect(searchResultsModal.exists).ok(); const userHasGrantsLink = Selector('a') .withAttribute('data-test-found-proxy-user')