Browser error message wrong for Windows

[Phillipus]

Browser error message for Windows refers to WebKit, this should be Edge.

eclipse.platform.swt/bundles/org.eclipse.swt/Eclipse SWT Browser/common/org/eclipse/swt/browser/Browser.java

Lines 115 to 117 in 823aeba

	case "win32":
	errMsg = errMsg + "SWT uses either IE or WebKit. Either the SWT.WEBKIT flag is passed and the WebKit library was not "
	+ "loaded properly by SWT, or SWT failed to load IE.\n";

Suggestions for correct message? I can provide PR if so.

[HeikoKlare]

Good catch. Webkit support has been removed from the win32 implementation several years ago: bcd8501

The message might be adapted by replacing IE with Edge and WebKit with IE (as Edge is the default and only the SWT.IE flag is relevant).

[Phillipus]

The message might be adapted by replacing IE with Edge and WebKit with IE (as Edge is the default and only the SWT.IE flag is relevant).

Is there a message some place else I recall seeing along the lines of "You need to download Edge runtime from...." that might be a more informative message?

[HeikoKlare]

That information on downloading Edge runtime is specific to the case that Edge instantiation fails. In my understanding, the code involved here is only executed when the createWebBrowser method returns false, which in turn is only the case if the browser factory returned null for the given browser style. I can only see this happen in the GTK implementation, so I am not even sure when this code may be executed in the Win32 and Cocoa implementation. So this might even be dead code on Windows and macOS (which makes it even more difficult to provide a more informative message 😉 ).