Skip to content

Commit 82eb196

Browse files
refactor(mw/com): update imports after memory utilities migration
- Update include paths from score_baselibs references - Adjust BUILD dependencies - Update namespace references in bindings and mocking
1 parent 19b83bb commit 82eb196

22 files changed

Lines changed: 70 additions & 67 deletions

score/mw/com/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ cc_library(
9595
deps = [
9696
"@score_baselibs//score/filesystem",
9797
"@score_baselibs//score/language/futurecpp",
98-
"//score/memory:string_literal",
98+
"@score_baselibs//score/string:string_literal",
9999
"@score_logging//score/mw/log",
100100
],
101101
)

score/mw/com/impl/bindings/lola/BUILD

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -454,7 +454,7 @@ cc_library(
454454
":application_id_pid_mapping_entry",
455455
":register_pid_fake",
456456
"@score_baselibs//score/containers:dynamic_array",
457-
"//score/memory/shared:atomic_indirector",
457+
"@score_baselibs//score/concurrency/atomic:atomic_indirector",
458458
"//score/memory/shared:types",
459459
],
460460
)
@@ -518,7 +518,7 @@ cc_library(
518518
":transaction_log_id",
519519
":transaction_log_set",
520520
"@score_baselibs//score/containers:dynamic_array",
521-
"//score/memory/shared:atomic_indirector",
521+
"@score_baselibs//score/concurrency/atomic:atomic_indirector",
522522
"//score/memory/shared:types",
523523
],
524524
)
@@ -564,7 +564,7 @@ cc_library(
564564
visibility = ["//score/mw/com/impl/bindings/lola:__subpackages__"],
565565
deps = [
566566
"//score/mw/com/impl/configuration",
567-
"//score/memory/shared:atomic_indirector",
567+
"@score_baselibs//score/concurrency/atomic:atomic_indirector",
568568
],
569569
)
570570

@@ -592,7 +592,7 @@ cc_library(
592592
":control_slot_types",
593593
":event_data_control",
594594
":event_slot_status",
595-
"//score/memory/shared:atomic_indirector",
595+
"@score_baselibs//score/concurrency/atomic:atomic_indirector",
596596
],
597597
)
598598

@@ -825,8 +825,8 @@ cc_gtest_unit_test(
825825
features = COMPILER_WARNING_FEATURES,
826826
deps = [
827827
":application_id_pid_mapping",
828-
"//score/memory/shared:atomic_indirector",
829-
"//score/memory/shared:atomic_indirector_mock_binding",
828+
"@score_baselibs//score/concurrency/atomic:atomic_indirector",
829+
"@score_baselibs//score/concurrency/atomic:atomic_indirector_mock_binding",
830830
],
831831
)
832832

@@ -917,7 +917,7 @@ cc_test(
917917
"@score_baselibs//score/containers:dynamic_array",
918918
"@score_baselibs//score/language/futurecpp",
919919
"@score_baselibs//score/language/safecpp/coverage_termination_handler",
920-
"//score/memory/shared:atomic_indirector_mock_binding",
920+
"@score_baselibs//score/concurrency/atomic:atomic_indirector_mock_binding",
921921
"//score/memory/shared:new_delete_delegate_resource",
922922
],
923923
)
@@ -933,7 +933,7 @@ cc_gtest_unit_test(
933933
"//score/mw/com/impl/bindings/lola/test_doubles:fake_memory_resource",
934934
"@score_baselibs//score/containers:dynamic_array",
935935
"@score_baselibs//score/language/futurecpp",
936-
"//score/memory/shared:atomic_indirector_mock_binding",
936+
"@score_baselibs//score/concurrency/atomic:atomic_indirector_mock_binding",
937937
"//score/memory/shared:new_delete_delegate_resource",
938938
],
939939
)
@@ -1126,7 +1126,7 @@ cc_gtest_unit_test(
11261126
deps = [
11271127
":event_subscription_control",
11281128
"//score/mw/com/impl/bindings/lola/test:proxy_event_test_resources",
1129-
"//score/memory/shared:atomic_indirector_mock_binding",
1129+
"@score_baselibs//score/concurrency/atomic:atomic_indirector_mock_binding",
11301130
],
11311131
)
11321132

score/mw/com/impl/bindings/lola/application_id_pid_mapping.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,12 +142,12 @@ std::optional<pid_t> RegisterPid(score::containers::DynamicArray<ApplicationIdPi
142142

143143
/// Instantiate the method templates once for AtomicIndirectorReal (production use) and AtomicIndirectorMock (testing)
144144
/// Those are all instantiations we need, so we are able to put the template definitions into the .cpp file.
145-
template std::optional<pid_t> RegisterPid<memory::shared::AtomicIndirectorMock>(
145+
template std::optional<pid_t> RegisterPid<concurrency::atomic::AtomicIndirectorMock>(
146146
score::containers::DynamicArray<ApplicationIdPidMappingEntry>::iterator entries_begin,
147147
score::containers::DynamicArray<ApplicationIdPidMappingEntry>::iterator entries_end,
148148
const std::uint32_t application_id,
149149
const pid_t pid);
150-
template std::optional<pid_t> RegisterPid<memory::shared::AtomicIndirectorReal>(
150+
template std::optional<pid_t> RegisterPid<concurrency::atomic::AtomicIndirectorReal>(
151151
score::containers::DynamicArray<ApplicationIdPidMappingEntry>::iterator entries_begin,
152152
score::containers::DynamicArray<ApplicationIdPidMappingEntry>::iterator entries_end,
153153
const std::uint32_t application_id,

score/mw/com/impl/bindings/lola/application_id_pid_mapping.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
#include "score/mw/com/impl/bindings/lola/register_pid_fake.h"
1818

1919
#include "score/containers/dynamic_array.h"
20-
#include "score/memory/shared/atomic_indirector.h"
20+
#include "score/concurrency/atomic/atomic_indirector.h"
2121

2222
#include <sys/types.h>
2323
#include <cstdint>
@@ -38,7 +38,7 @@ namespace detail
3838
// Suppress "AUTOSAR C++14 M3-2-3" rule finding. This rule states: "A type, object or function that is used in multiple
3939
// translation units shall be declared in one and only one file.".
4040
// coverity[autosar_cpp14_m3_2_3_violation] This is false positive. Function is declared only once.
41-
template <template <class> class AtomicIndirectorType = memory::shared::AtomicIndirectorReal>
41+
template <template <class> class AtomicIndirectorType = concurrency::atomic::AtomicIndirectorReal>
4242
// coverity[autosar_cpp14_m3_2_3_violation] This is false positive. Function is declared only once.
4343
std::optional<pid_t> RegisterPid(score::containers::DynamicArray<ApplicationIdPidMappingEntry>::iterator entries_begin,
4444
score::containers::DynamicArray<ApplicationIdPidMappingEntry>::iterator entries_end,
@@ -111,7 +111,7 @@ class ApplicationIdPidMapping
111111
// element. Therefore, the provided assertions check this rule requirement, whether the iterators return a
112112
// result other than nullptr.
113113
// coverity[autosar_cpp14_a5_3_2_violation]
114-
return detail::RegisterPid<memory::shared::AtomicIndirectorReal>(
114+
return detail::RegisterPid<concurrency::atomic::AtomicIndirectorReal>(
115115
mapping_entries_.begin(), mapping_entries_.end(), application_id, pid);
116116
};
117117

score/mw/com/impl/bindings/lola/application_id_pid_mapping_test.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
********************************************************************************/
1313
#include "score/mw/com/impl/bindings/lola/application_id_pid_mapping.h"
1414

15-
#include "score/memory/shared/atomic_indirector.h"
16-
#include "score/memory/shared/atomic_mock.h"
15+
#include "score/concurrency/atomic/atomic_indirector.h"
16+
#include "score/concurrency/atomic/atomic_mock.h"
1717

1818
#include <gtest/gtest.h>
1919

@@ -71,15 +71,15 @@ TEST(ApplicationIdPidMapping, RegisterMaxRetryFailure)
7171
}
7272
}
7373

74-
memory::shared::AtomicMock<ApplicationIdPidMappingEntry::key_type> atomic_mock{};
75-
memory::shared::AtomicIndirectorMock<ApplicationIdPidMappingEntry::key_type>::SetMockObject(&atomic_mock);
74+
concurrency::atomic::AtomicMock<ApplicationIdPidMappingEntry::key_type> atomic_mock{};
75+
concurrency::atomic::AtomicIndirectorMock<ApplicationIdPidMappingEntry::key_type>::SetMockObject(&atomic_mock);
7676

7777
const std::size_t kMaxRetries{50};
7878
// Given the operation to update the mapping entry fails kMaxRetries times
7979
EXPECT_CALL(atomic_mock, compare_exchange_weak(_, _, _)).Times(kMaxRetries).WillRepeatedly(Return(false));
8080

8181
// when trying to register a new application_id 42 (not among the registered application_ids)
82-
auto result = lola::detail::RegisterPid<memory::shared::AtomicIndirectorMock>(
82+
auto result = lola::detail::RegisterPid<concurrency::atomic::AtomicIndirectorMock>(
8383
mapping_entries.begin(), mapping_entries.end(), 42, 142);
8484
// expect, that an empty optional is returned.
8585
EXPECT_FALSE(result.has_value());

score/mw/com/impl/bindings/lola/event_data_control.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -449,7 +449,7 @@ auto EventDataControlImpl<AtomicIndirectorType>::ResetPerformanceCounters() -> v
449449
num_ref_retries.store(0U);
450450
}
451451

452-
template class EventDataControlImpl<memory::shared::AtomicIndirectorReal>;
453-
template class EventDataControlImpl<memory::shared::AtomicIndirectorMock>;
452+
template class EventDataControlImpl<concurrency::atomic::AtomicIndirectorReal>;
453+
template class EventDataControlImpl<concurrency::atomic::AtomicIndirectorMock>;
454454

455455
} // namespace score::mw::com::impl::lola::detail_event_data_control

score/mw/com/impl/bindings/lola/event_data_control.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
#include "score/memory/shared/memory_resource_proxy.h"
2424
#include "score/memory/shared/polymorphic_offset_ptr_allocator.h"
2525

26-
#include "score/memory/shared/atomic_indirector.h"
26+
#include "score/concurrency/atomic/atomic_indirector.h"
2727

2828
#include "score/containers/dynamic_array.h"
2929

@@ -68,7 +68,7 @@ namespace detail_event_data_control
6868
/// a process).
6969
///
7070
/// It is one of the corner stone elements of our LoLa IPC for Events!
71-
template <template <class> class AtomicIndirectorType = memory::shared::AtomicIndirectorReal>
71+
template <template <class> class AtomicIndirectorType = concurrency::atomic::AtomicIndirectorReal>
7272
class EventDataControlImpl final
7373
{
7474
// Suppress "AUTOSAR C++14 A11-3-1", The rule declares: "Friend declarations shall not be used".

score/mw/com/impl/bindings/lola/event_data_control_composite.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,7 @@ EventSlotStatus::EventTimeStamp EventDataControlCompositeImpl<AtomicIndirectorTy
343343
return latest_time_stamp;
344344
}
345345

346-
template class EventDataControlCompositeImpl<memory::shared::AtomicIndirectorReal>;
347-
template class EventDataControlCompositeImpl<memory::shared::AtomicIndirectorMock>;
346+
template class EventDataControlCompositeImpl<concurrency::atomic::AtomicIndirectorReal>;
347+
template class EventDataControlCompositeImpl<concurrency::atomic::AtomicIndirectorMock>;
348348

349349
} // namespace score::mw::com::impl::lola::detail_event_data_control_composite

score/mw/com/impl/bindings/lola/event_data_control_composite.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
#include "score/mw/com/impl/bindings/lola/event_data_control.h"
1919
#include "score/mw/com/impl/bindings/lola/event_slot_status.h"
2020

21-
#include "score/memory/shared/atomic_indirector.h"
21+
#include "score/concurrency/atomic/atomic_indirector.h"
2222

2323
#include <optional>
2424
#include <tuple>
@@ -39,7 +39,7 @@ namespace detail_event_data_control_composite
3939
/// whole codebase, we implemented this composite which takes care of setting the status correctly in all underlying
4040
/// control structures. Please be aware that the control structures will live in different shared memory segments, thus
4141
/// it is not possible to store them by value, but rather as pointer.
42-
template <template <class> class AtomicIndirectorType = memory::shared::AtomicIndirectorReal>
42+
template <template <class> class AtomicIndirectorType = concurrency::atomic::AtomicIndirectorReal>
4343
class EventDataControlCompositeImpl
4444
{
4545
// Suppress "AUTOSAR C++14 A11-3-1", The rule declares: "Friend declarations shall not be used".

score/mw/com/impl/bindings/lola/event_data_control_composite_test.cpp

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
#include "score/mw/com/impl/bindings/lola/transaction_log_set.h"
1717
#include "score/mw/com/impl/instance_specifier.h"
1818

19-
#include "score/memory/shared/atomic_indirector.h"
20-
#include "score/memory/shared/atomic_mock.h"
19+
#include "score/concurrency/atomic/atomic_indirector.h"
20+
#include "score/concurrency/atomic/atomic_mock.h"
2121
#include "score/memory/shared/new_delete_delegate_resource.h"
2222

2323
#include <score/assert.hpp>
@@ -104,12 +104,12 @@ class EventDataControlCompositeFixture : public ::testing::Test
104104
{
105105
SCORE_LANGUAGE_FUTURECPP_ASSERT(qm_ != nullptr);
106106

107-
atomic_mock_ = std::make_unique<memory::shared::AtomicMock<EventSlotStatus::value_type>>();
108-
memory::shared::AtomicIndirectorMock<EventSlotStatus::value_type>::SetMockObject(atomic_mock_.get());
107+
atomic_mock_ = std::make_unique<concurrency::atomic::AtomicMock<EventSlotStatus::value_type>>();
108+
concurrency::atomic::AtomicIndirectorMock<EventSlotStatus::value_type>::SetMockObject(atomic_mock_.get());
109109

110110
auto* const asil_control = asil_ != nullptr ? asil_.get() : nullptr;
111111
unit_mock_ = std::make_unique<
112-
detail_event_data_control_composite::EventDataControlCompositeImpl<memory::shared::AtomicIndirectorMock>>(
112+
detail_event_data_control_composite::EventDataControlCompositeImpl<concurrency::atomic::AtomicIndirectorMock>>(
113113
qm_.get(), asil_control);
114114

115115
return *this;
@@ -161,9 +161,9 @@ class EventDataControlCompositeFixture : public ::testing::Test
161161
std::unique_ptr<EventDataControl> qm_{nullptr};
162162
std::unique_ptr<EventDataControlComposite> unit_{nullptr};
163163

164-
std::unique_ptr<memory::shared::AtomicMock<EventSlotStatus::value_type>> atomic_mock_{nullptr};
164+
std::unique_ptr<concurrency::atomic::AtomicMock<EventSlotStatus::value_type>> atomic_mock_{nullptr};
165165
std::unique_ptr<
166-
detail_event_data_control_composite::EventDataControlCompositeImpl<memory::shared::AtomicIndirectorMock>>
166+
detail_event_data_control_composite::EventDataControlCompositeImpl<concurrency::atomic::AtomicIndirectorMock>>
167167
unit_mock_{nullptr};
168168

169169
std::unique_ptr<TransactionLogSet::TransactionLogIndex> transaction_log_index_qm_{nullptr};

0 commit comments

Comments
 (0)